Clarify thirdparty label/annotations on the maintenance jobs#8930
Merged
Conversation
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
added
the
kind/changelog-not-required
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8930 +/- ##
=======================================
Coverage 59.57% 59.57%
=======================================
Files 370 370
Lines 40278 40278
=======================================
Hits 23995 23995
Misses 14780 14780
Partials 1503 1503 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lyndon-Li
previously approved these changes
May 19, 2025
blackpiglet
approved these changes
May 19, 2025
3 tasks
blackpiglet
reviewed
May 28, 2025
blackpiglet
reviewed
May 28, 2025
blackpiglet
requested changes
May 28, 2025
Contributor
blackpiglet
left a comment
blackpiglet
left a comment
There was a problem hiding this comment.
Please make some changes to also address the issue mentioned in #8974.
- Address PR review feedback and issue velero-io#8974 - Make it explicit that only specific predefined third-party labels and annotations are propagated - Add Important note to prevent user confusion about label/annotation inheritance behavior - Currently only azure.workload.identity/use label and iam.amazonaws.com/role annotation are inherited Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
blackpiglet
approved these changes
May 28, 2025
Lyndon-Li
approved these changes
Jul 9, 2025
3 tasks
MaloLelandais
pushed a commit
to MaloLelandais/velero
that referenced
this pull request
Jul 28, 2025
…io#8930) * Clarify thirdparty label/annotations on the maintenance jobs Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Clarify that maintenance jobs do not inherit all labels/annotations - Address PR review feedback and issue velero-io#8974 - Make it explicit that only specific predefined third-party labels and annotations are propagated - Add Important note to prevent user confusion about label/annotation inheritance behavior - Currently only azure.workload.identity/use label and iam.amazonaws.com/role annotation are inherited Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> --------- Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-authored-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.