Skip to content

[cherry-pick]Call WaitGroup.Done() once only when PVB changes to final status the first time to avoid panic#8941

Merged
ywk253100 merged 1 commit into
velero-io:mainfrom
ywk253100:250514_fix_main
May 15, 2025
Merged

[cherry-pick]Call WaitGroup.Done() once only when PVB changes to final status the first time to avoid panic#8941
ywk253100 merged 1 commit into
velero-io:mainfrom
ywk253100:250514_fix_main

Conversation

@ywk253100
Copy link
Copy Markdown
Contributor

Call WaitGroup.Done() once only when PVB changes to final status the first time to avoid panic

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

…first time to avoid panic

Call WaitGroup.Done() once only when PVB changes to final status the first time to avoid
panic

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
@ywk253100 ywk253100 added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label May 14, 2025
@github-actions github-actions Bot requested review from Lyndon-Li and reasonerjt May 14, 2025 09:27
@ywk253100 ywk253100 requested a review from blackpiglet May 14, 2025 09:28
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.57%. Comparing base (c2695c3) to head (5ba4bd1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/podvolume/backupper.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8941   +/-   ##
=======================================
  Coverage   59.56%   59.57%           
=======================================
  Files         370      370           
  Lines       40267    40278   +11     
=======================================
+ Hits        23987    23995    +8     
- Misses      14778    14780    +2     
- Partials     1502     1503    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ywk253100 ywk253100 merged commit 4c23f66 into velero-io:main May 15, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants