Extend PVCAction itemblock plugin to support grouping PVCs under VGS label key#8944
Merged
shubham-pampattiwar merged 1 commit intoJun 11, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8944 +/- ##
==========================================
+ Coverage 59.81% 59.84% +0.02%
==========================================
Files 375 375
Lines 41056 41100 +44
==========================================
+ Hits 24557 24595 +38
- Misses 15010 15014 +4
- Partials 1489 1491 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
74b18b8 to
f23f3b9
Compare
kaovilai
reviewed
May 30, 2025
kaovilai
reviewed
May 30, 2025
kaovilai
reviewed
May 30, 2025
Member
Code Review Summary ✅Great work on implementing VGS support in the PVC ItemBlockAction plugin! This is a solid implementation that addresses issue #8935 requirements. Overall Assessment:
Key Strengths:
Minor Enhancement Opportunities (within PR scope):I've added specific code review comments for:
Test Coverage:The test suite is comprehensive. Consider adding one more edge case for empty group values to complete the coverage. Looking forward to seeing this land! 🚀 |
f23f3b9 to
8310994
Compare
Collaborator
Author
|
@sseago Addressed #8938 (review) in this PR ! |
kaovilai
reviewed
Jun 2, 2025
sseago
reviewed
Jun 2, 2025
8310994 to
0084e4a
Compare
kaovilai
reviewed
Jun 3, 2025
0084e4a to
dafaf70
Compare
6769c6c to
3fa9280
Compare
3fa9280 to
aee5132
Compare
sseago
approved these changes
Jun 5, 2025
aee5132 to
1ff8500
Compare
…meGroupSnapshot label Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> Add changelog file Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> Update VGS label key and address PR feedback Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> update log level to debug for edge cases Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> Change VGS label key constant location Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> run make update Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
1ff8500 to
97a4d62
Compare
Collaborator
Author
|
@Lyndon-Li @blackpiglet @kaovilai PR review request ! |
kaovilai
approved these changes
Jun 11, 2025
Lyndon-Li
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #8935
Related to sub-task of #8865
Depends on merging #8938Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.