Skip to content

Add .config/ to .gitignore#9006

Merged
ywk253100 merged 1 commit intovelero-io:mainfrom
kaovilai:improve-config-gitignore-comment
Jun 9, 2025
Merged

Add .config/ to .gitignore#9006
ywk253100 merged 1 commit intovelero-io:mainfrom
kaovilai:improve-config-gitignore-comment

Conversation

@kaovilai
Copy link
Copy Markdown
Collaborator

@kaovilai kaovilai commented Jun 6, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Add .config/ directory to .gitignore with detailed explanation of why this directory gets created during builds.

The .config/ directory is created by Go's telemetry system when the Makefile uses docker run -w /github.com/vmware-tanzu/velero. This sets the container's HOME environment variable to the working directory, causing Go's os.UserConfigDir() to fall back to $HOME/.config when XDG_CONFIG_HOME is unset, creating .config/ in the project root.

Does your change fix a particular issue?

This prevents the .config/ directory (created during builds) from appearing as an untracked file in git status.

Please indicate you've done the following:

@github-actions github-actions Bot requested review from reasonerjt and ywk253100 June 6, 2025 14:53
@kaovilai kaovilai force-pushed the improve-config-gitignore-comment branch from 80bfe59 to 2f663aa Compare June 6, 2025 14:53
Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai force-pushed the improve-config-gitignore-comment branch from 2f663aa to 90d13bb Compare June 6, 2025 14:54
@kaovilai kaovilai added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jun 6, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.84%. Comparing base (f8b799d) to head (90d13bb).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9006      +/-   ##
==========================================
+ Coverage   59.61%   59.84%   +0.22%     
==========================================
  Files         374      375       +1     
  Lines       40726    41046     +320     
==========================================
+ Hits        24280    24563     +283     
- Misses      14963    14996      +33     
- Partials     1483     1487       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ywk253100 ywk253100 merged commit eafa48d into velero-io:main Jun 9, 2025
46 of 47 checks passed
@kaovilai kaovilai deleted the improve-config-gitignore-comment branch April 8, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants