Skip to content

Refactor affinity tests to use require and assert for better readability and error reporting#9009

Merged
blackpiglet merged 1 commit intovelero-io:mainfrom
mmorel-35:simplify-test-logic
Jun 9, 2025
Merged

Refactor affinity tests to use require and assert for better readability and error reporting#9009
blackpiglet merged 1 commit intovelero-io:mainfrom
mmorel-35:simplify-test-logic

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

@mmorel-35 mmorel-35 commented Jun 7, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Refactor affinity tests to use require and assert for better readability and error reporting

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@mmorel-35
Copy link
Copy Markdown
Contributor Author

/kind changelog-not-required

@github-actions github-actions Bot added has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes labels Jun 7, 2025
@mmorel-35 mmorel-35 force-pushed the simplify-test-logic branch from 605b0ad to dd6b368 Compare June 7, 2025 08:37
@mmorel-35 mmorel-35 marked this pull request as ready for review June 7, 2025 08:38
@github-actions github-actions Bot requested review from Lyndon-Li and reasonerjt June 7, 2025 08:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.81%. Comparing base (6447363) to head (00ce103).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9009   +/-   ##
=======================================
  Coverage   59.80%   59.81%           
=======================================
  Files         375      375           
  Lines       41056    41056           
=======================================
+ Hits        24554    24557    +3     
+ Misses      15012    15010    -2     
+ Partials     1490     1489    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ity and error reporting

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the simplify-test-logic branch from dd6b368 to 00ce103 Compare June 9, 2025 05:33
@blackpiglet blackpiglet merged commit 41a6922 into velero-io:main Jun 9, 2025
46 checks passed
@mmorel-35 mmorel-35 deleted the simplify-test-logic branch June 9, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants