Fix wildcard expansion when includes is empty and excludes has wildcards by Joeavaikath · Pull Request #9684 · velero-io/velero

Joeavaikath · 2026-04-08T12:33:14Z

Summary

When a Backup CR is created via kubectl apply with empty includedNamespaces
and a wildcard pattern in excludedNamespaces (e.g., test-backup*),
ShouldExpandWildcards triggers expansion. The empty includes expands to nil,
but wildcardExpanded is set to true, causing ShouldInclude to return false
for all namespaces — effectively backing up nothing.

This fix normalizes empty IncludedNamespaces to ["*"] in the backup
controller's prepareBackupRequest, before any downstream processing. This:

Prevents the wildcardExpanded + empty includes guard from rejecting everything
Matches the CLI path's behavior where includes defaults to ["*"]
Ensures consistent Namespace CR inclusion — excluded namespaces' Namespace
objects are still backed up, matching Velero's intentional behavior
(see item_backupper.go itemInclusionChecks)

Changes

pkg/controller/backup_controller.go: In prepareBackupRequest(), normalize empty IncludedNamespaces to ["*"] before namespace validation
pkg/controller/backup_controller_test.go: Add test verifying empty includes is normalized to ["*"]

Test plan

Existing tests pass (go test ./pkg/controller/ ./pkg/util/collections/ ./pkg/util/wildcard/)
New test: TestPrepareBackupRequest_EmptyIncludedNamespacesNormalizedToWildcard verifies normalization
Manual: kubectl apply a Backup CR with empty includedNamespaces and wildcard excludedNamespaces — verify correct namespaces are backed up
[ ]

Please indicate you've done the following:

Accepted the DCO. Commits without the DCO will delay acceptance.
Created a changelog file (make new-changelog) or comment /kind changelog-not-required on this PR.
Updated the corresponding documentation in site/content/docs/main.- [ ]

When a Backup CR is applied via kubectl with empty includedNamespaces and a wildcard in excludedNamespaces, ShouldExpandWildcards triggers expansion. The empty includes expands to nil, but wildcardExpanded is set to true, causing ShouldInclude to return false for all namespaces. Populate expanded includes with all active namespaces when the original includes was empty (meaning "include all") so that the wildcardExpanded check does not falsely reject everything. Signed-off-by: Joseph <jvaikath@redhat.com>

Signed-off-by: Joseph <jvaikath@redhat.com>

codecov · 2026-04-08T12:44:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

This ensures consistent behavior between CLI and kubectl-apply paths for Namespace CR inclusion when excludes contain wildcards. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com>

Instead of normalizing empty IncludedNamespaces to ["*"] in the collections layer's ExpandIncludesExcludes, do it earlier in prepareBackupRequest. This ensures the spec is correct before any downstream processing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com>

Add IncludedNamespaces: []string{"*"} to all expected BackupSpec structs, reflecting the new prepareBackupRequest normalization. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com>

Lyndon-Li · 2026-04-21T03:55:53Z

@Joeavaikath Could you check if all the comments have been addressed so this PR could be merged? This is a task of 1.18.1 which will be RC very soon.
Please also help to make a cherry-pick after it is merged.

Signed-off-by: Joseph <jvaikath@redhat.com>

blackpiglet · 2026-04-22T00:31:44Z

 func ShouldExpandWildcards(includes []string, excludes []string) bool {
+	// Empty includes is equivalent to * (match all) - don't expand
+	if len(includes) == 0 {
+		return false


The fix is reasonable for the main branch now, but release-1.18 expands asterisk.
We should consider that and make modifications accordingly for release-1.18.

Will backport to release-1.18 branch

…rds (velero-io#9684) * Fix wildcard expansion when includes is empty and excludes has wildcards When a Backup CR is applied via kubectl with empty includedNamespaces and a wildcard in excludedNamespaces, ShouldExpandWildcards triggers expansion. The empty includes expands to nil, but wildcardExpanded is set to true, causing ShouldInclude to return false for all namespaces. Populate expanded includes with all active namespaces when the original includes was empty (meaning "include all") so that the wildcardExpanded check does not falsely reject everything. Signed-off-by: Joseph <jvaikath@redhat.com> * Changelog Signed-off-by: Joseph <jvaikath@redhat.com> * Normalize empty includes to * instead of active namespaces list This ensures consistent behavior between CLI and kubectl-apply paths for Namespace CR inclusion when excludes contain wildcards. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Move empty includes normalization to backup controller Instead of normalizing empty IncludedNamespaces to ["*"] in the collections layer's ExpandIncludesExcludes, do it earlier in prepareBackupRequest. This ensures the spec is correct before any downstream processing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Update TestProcessBackupCompletions for wildcard normalization Add IncludedNamespaces: []string{"*"} to all expected BackupSpec structs, reflecting the new prepareBackupRequest normalization. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Add checks around empty includenamespaces Signed-off-by: Joseph <jvaikath@redhat.com> * gofmt Signed-off-by: Joseph <jvaikath@redhat.com> --------- Signed-off-by: Joseph <jvaikath@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…rds (velero-io#9684) * Fix wildcard expansion when includes is empty and excludes has wildcards When a Backup CR is applied via kubectl with empty includedNamespaces and a wildcard in excludedNamespaces, ShouldExpandWildcards triggers expansion. The empty includes expands to nil, but wildcardExpanded is set to true, causing ShouldInclude to return false for all namespaces. Populate expanded includes with all active namespaces when the original includes was empty (meaning "include all") so that the wildcardExpanded check does not falsely reject everything. Signed-off-by: Joseph <jvaikath@redhat.com> * Changelog Signed-off-by: Joseph <jvaikath@redhat.com> * Normalize empty includes to * instead of active namespaces list This ensures consistent behavior between CLI and kubectl-apply paths for Namespace CR inclusion when excludes contain wildcards. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Move empty includes normalization to backup controller Instead of normalizing empty IncludedNamespaces to ["*"] in the collections layer's ExpandIncludesExcludes, do it earlier in prepareBackupRequest. This ensures the spec is correct before any downstream processing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Update TestProcessBackupCompletions for wildcard normalization Add IncludedNamespaces: []string{"*"} to all expected BackupSpec structs, reflecting the new prepareBackupRequest normalization. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Add checks around empty includenamespaces Signed-off-by: Joseph <jvaikath@redhat.com> * gofmt Signed-off-by: Joseph <jvaikath@redhat.com> --------- Signed-off-by: Joseph <jvaikath@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>

…rds (velero-io#9684) * Fix wildcard expansion when includes is empty and excludes has wildcards When a Backup CR is applied via kubectl with empty includedNamespaces and a wildcard in excludedNamespaces, ShouldExpandWildcards triggers expansion. The empty includes expands to nil, but wildcardExpanded is set to true, causing ShouldInclude to return false for all namespaces. Populate expanded includes with all active namespaces when the original includes was empty (meaning "include all") so that the wildcardExpanded check does not falsely reject everything. Signed-off-by: Joseph <jvaikath@redhat.com> * Changelog Signed-off-by: Joseph <jvaikath@redhat.com> * Normalize empty includes to * instead of active namespaces list This ensures consistent behavior between CLI and kubectl-apply paths for Namespace CR inclusion when excludes contain wildcards. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Move empty includes normalization to backup controller Instead of normalizing empty IncludedNamespaces to ["*"] in the collections layer's ExpandIncludesExcludes, do it earlier in prepareBackupRequest. This ensures the spec is correct before any downstream processing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Update TestProcessBackupCompletions for wildcard normalization Add IncludedNamespaces: []string{"*"} to all expected BackupSpec structs, reflecting the new prepareBackupRequest normalization. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Add checks around empty includenamespaces Signed-off-by: Joseph <jvaikath@redhat.com> * gofmt Signed-off-by: Joseph <jvaikath@redhat.com> --------- Signed-off-by: Joseph <jvaikath@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

@blackpiglet

* fix: lint permission issue Signed-off-by: emirot <emirot.nolan@gmail.com> * fix: lint permission issue Signed-off-by: emirot <emirot.nolan@gmail.com> * Set permissions to the actions This commit update the actions "Auto Assign Author", "Auto Label PRs", and "Auto Request Review" Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Fix wildcard expansion when includes is empty and excludes has wildcards (#9684) * Fix wildcard expansion when includes is empty and excludes has wildcards When a Backup CR is applied via kubectl with empty includedNamespaces and a wildcard in excludedNamespaces, ShouldExpandWildcards triggers expansion. The empty includes expands to nil, but wildcardExpanded is set to true, causing ShouldInclude to return false for all namespaces. Populate expanded includes with all active namespaces when the original includes was empty (meaning "include all") so that the wildcardExpanded check does not falsely reject everything. Signed-off-by: Joseph <jvaikath@redhat.com> * Changelog Signed-off-by: Joseph <jvaikath@redhat.com> * Normalize empty includes to * instead of active namespaces list This ensures consistent behavior between CLI and kubectl-apply paths for Namespace CR inclusion when excludes contain wildcards. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Move empty includes normalization to backup controller Instead of normalizing empty IncludedNamespaces to ["*"] in the collections layer's ExpandIncludesExcludes, do it earlier in prepareBackupRequest. This ensures the spec is correct before any downstream processing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Update TestProcessBackupCompletions for wildcard normalization Add IncludedNamespaces: []string{"*"} to all expected BackupSpec structs, reflecting the new prepareBackupRequest normalization. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Add checks around empty includenamespaces Signed-off-by: Joseph <jvaikath@redhat.com> * gofmt Signed-off-by: Joseph <jvaikath@redhat.com> --------- Signed-off-by: Joseph <jvaikath@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * update hashicorp/go-hclog and go-plugin to current version (#9613) Signed-off-by: Peter Woodman <peter@shortbus.org> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix: honor -stderrthreshold when -logtostderr is true (default) klog v2 defaults -logtostderr to true, which silently ignores the -stderrthreshold flag — all log levels are unconditionally sent to stderr. This makes it impossible for log-aggregation systems to filter by severity. Bump klog to v2.140.0 and opt into the fixed behavior by setting legacy_stderr_threshold_behavior=false and stderrthreshold=INFO (which preserves current output while letting users override via CLI flags). Ref: kubernetes/klog#212, kubernetes/klog#432 Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix: add changelog and nolint explanation for CI Add missing changelog entry for PR 9654 (fixes Changelog Check). Add explanation to //nolint:errcheck directives (fixes nolintlint). Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Remove Restic code path from PodVolumeRestore. Signed-off-by: Xun Jiang <xun.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Bump go.opentelemetry.io/otel from 1.40.0 to 1.41.0 Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.40.0 to 1.41.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.40.0...v1.41.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel dependency-version: 1.41.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Fix error in auto-request-review action Per action.yml of the action, the token is required. https://github.com/necojackarc/auto-request-review/blob/e89da1a8cd7c8c16d9de9c6e763290b6b0e3d424/action.yml#L8 Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix go-releaser upload error Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * add concurrency limit to go-releaser Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Bump go.opentelemetry.io/otel/sdk from 1.40.0 to 1.43.0 (#9692) Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.40.0 to 1.43.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.40.0...v1.43.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-version: 1.43.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix(lint): fix lint local Signed-off-by: emirot <emirot.nolan@gmail.com> * Apply suggestion from @blackpiglet https://github.com/velero-io/velero/pull/9740/changes#r3151366281 Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> --------- Signed-off-by: emirot <emirot.nolan@gmail.com> Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: Joseph <jvaikath@redhat.com> Signed-off-by: Peter Woodman <peter@shortbus.org> Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: Xun Jiang <xun.jiang@broadcom.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> Co-authored-by: Daniel Jiang <daniel.jiang@broadcom.com> Co-authored-by: Joseph Antony Vaikath <jvaikath@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: peter woodman <peter@shortbus.org> Co-authored-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Co-authored-by: Xun Jiang <xun.jiang@broadcom.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lyndon-Li <lyonghui@vmware.com> Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

@blackpiglet

* fix: lint permission issue Signed-off-by: emirot <emirot.nolan@gmail.com> * fix: lint permission issue Signed-off-by: emirot <emirot.nolan@gmail.com> * Set permissions to the actions This commit update the actions "Auto Assign Author", "Auto Label PRs", and "Auto Request Review" Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Fix wildcard expansion when includes is empty and excludes has wildcards (velero-io#9684) * Fix wildcard expansion when includes is empty and excludes has wildcards When a Backup CR is applied via kubectl with empty includedNamespaces and a wildcard in excludedNamespaces, ShouldExpandWildcards triggers expansion. The empty includes expands to nil, but wildcardExpanded is set to true, causing ShouldInclude to return false for all namespaces. Populate expanded includes with all active namespaces when the original includes was empty (meaning "include all") so that the wildcardExpanded check does not falsely reject everything. Signed-off-by: Joseph <jvaikath@redhat.com> * Changelog Signed-off-by: Joseph <jvaikath@redhat.com> * Normalize empty includes to * instead of active namespaces list This ensures consistent behavior between CLI and kubectl-apply paths for Namespace CR inclusion when excludes contain wildcards. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Move empty includes normalization to backup controller Instead of normalizing empty IncludedNamespaces to ["*"] in the collections layer's ExpandIncludesExcludes, do it earlier in prepareBackupRequest. This ensures the spec is correct before any downstream processing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Update TestProcessBackupCompletions for wildcard normalization Add IncludedNamespaces: []string{"*"} to all expected BackupSpec structs, reflecting the new prepareBackupRequest normalization. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joseph <jvaikath@redhat.com> * Add checks around empty includenamespaces Signed-off-by: Joseph <jvaikath@redhat.com> * gofmt Signed-off-by: Joseph <jvaikath@redhat.com> --------- Signed-off-by: Joseph <jvaikath@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * update hashicorp/go-hclog and go-plugin to current version (velero-io#9613) Signed-off-by: Peter Woodman <peter@shortbus.org> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix: honor -stderrthreshold when -logtostderr is true (default) klog v2 defaults -logtostderr to true, which silently ignores the -stderrthreshold flag — all log levels are unconditionally sent to stderr. This makes it impossible for log-aggregation systems to filter by severity. Bump klog to v2.140.0 and opt into the fixed behavior by setting legacy_stderr_threshold_behavior=false and stderrthreshold=INFO (which preserves current output while letting users override via CLI flags). Ref: kubernetes/klog#212, kubernetes/klog#432 Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix: add changelog and nolint explanation for CI Add missing changelog entry for PR 9654 (fixes Changelog Check). Add explanation to //nolint:errcheck directives (fixes nolintlint). Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Remove Restic code path from PodVolumeRestore. Signed-off-by: Xun Jiang <xun.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Bump go.opentelemetry.io/otel from 1.40.0 to 1.41.0 Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.40.0 to 1.41.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.40.0...v1.41.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel dependency-version: 1.41.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Fix error in auto-request-review action Per action.yml of the action, the token is required. https://github.com/necojackarc/auto-request-review/blob/e89da1a8cd7c8c16d9de9c6e763290b6b0e3d424/action.yml#L8 Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix go-releaser upload error Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * add concurrency limit to go-releaser Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * Bump go.opentelemetry.io/otel/sdk from 1.40.0 to 1.43.0 (velero-io#9692) Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.40.0 to 1.43.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.40.0...v1.43.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-version: 1.43.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * fix(lint): fix lint local Signed-off-by: emirot <emirot.nolan@gmail.com> * Apply suggestion from @blackpiglet https://github.com/velero-io/velero/pull/9740/changes#r3151366281 Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> --------- Signed-off-by: emirot <emirot.nolan@gmail.com> Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com> Signed-off-by: Joseph <jvaikath@redhat.com> Signed-off-by: Peter Woodman <peter@shortbus.org> Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Signed-off-by: Xun Jiang <xun.jiang@broadcom.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Lyndon-Li <lyonghui@vmware.com> Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> Co-authored-by: Daniel Jiang <daniel.jiang@broadcom.com> Co-authored-by: Joseph Antony Vaikath <jvaikath@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: peter woodman <peter@shortbus.org> Co-authored-by: Pierluigi Lenoci <pierluigilenoci@gmail.com> Co-authored-by: Xun Jiang <xun.jiang@broadcom.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lyndon-Li <lyonghui@vmware.com> Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>

github-actions Bot assigned Joeavaikath Apr 8, 2026

github-actions Bot requested review from anshulahuja98 and ywk253100 April 8, 2026 12:33

github-actions Bot added the has-unit-tests label Apr 8, 2026

Changelog

aedb52d

Signed-off-by: Joseph <jvaikath@redhat.com>

github-actions Bot added the has-changelog label Apr 8, 2026

Joeavaikath force-pushed the fix/wildcard-empty-includes-excludes branch from e5053bb to f75da02 Compare April 8, 2026 15:15

blackpiglet reviewed Apr 8, 2026

View reviewed changes

Comment thread pkg/util/collections/includes_excludes.go Outdated

Joeavaikath and others added 2 commits April 8, 2026 15:10

blackpiglet previously approved these changes Apr 13, 2026

View reviewed changes

reasonerjt requested review from kaovilai and shubham-pampattiwar April 13, 2026 06:44

shubham-pampattiwar reviewed Apr 13, 2026

View reviewed changes

Comment thread pkg/controller/backup_controller.go

Comment thread pkg/controller/backup_controller_test.go

Add checks around empty includenamespaces

aa0a620

Signed-off-by: Joseph <jvaikath@redhat.com>

Joeavaikath dismissed blackpiglet’s stale review via aa0a620 April 21, 2026 12:39

gofmt

fa6d949

Signed-off-by: Joseph <jvaikath@redhat.com>

shubham-pampattiwar approved these changes Apr 22, 2026

View reviewed changes

blackpiglet reviewed Apr 22, 2026

View reviewed changes

blackpiglet approved these changes Apr 22, 2026

View reviewed changes

Merge branch 'main' into fix/wildcard-empty-includes-excludes

16d956e

shubham-pampattiwar merged commit 3b34fb8 into velero-io:main Apr 22, 2026
57 checks passed

shubham-pampattiwar mentioned this pull request Apr 23, 2026

Auto-exclude Velero namespace from backups instead of hard error #9615

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix wildcard expansion when includes is empty and excludes has wildcards#9684

Fix wildcard expansion when includes is empty and excludes has wildcards#9684
shubham-pampattiwar merged 8 commits intovelero-io:mainfrom
Joeavaikath:fix/wildcard-empty-includes-excludes

Joeavaikath commented Apr 8, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lyndon-Li commented Apr 21, 2026 •

edited

Loading

Uh oh!

blackpiglet Apr 22, 2026

Uh oh!

Joeavaikath Apr 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Joeavaikath commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Please indicate you've done the following:

Uh oh!

codecov Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lyndon-Li commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blackpiglet Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Joeavaikath Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Joeavaikath commented Apr 8, 2026 •

edited

Loading

codecov Bot commented Apr 8, 2026 •

edited

Loading

Lyndon-Li commented Apr 21, 2026 •

edited

Loading