Skip to content

Backport PR #9693 and #9700 to Release-1.16#9726

Merged
kaovilai merged 4 commits intovelero-io:release-1.16from
priyansh17:user/priyansh/backport-9693-9700
Apr 16, 2026
Merged

Backport PR #9693 and #9700 to Release-1.16#9726
kaovilai merged 4 commits intovelero-io:release-1.16from
priyansh17:user/priyansh/backport-9693-9700

Conversation

@priyansh17
Copy link
Copy Markdown
Collaborator

@priyansh17 priyansh17 commented Apr 15, 2026

Thank you for contributing to Velero!

Please add a summary of your change

This is backporting of PRs #9693 and #9700 in main branch to release-1.16.

Please indicate you've done the following:

…elero-io#9693)

* Enhance backup deletion logic to handle tarball download failures and clean up associated CSI VolumeSnapshotContents
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* added changelog
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* Refactor error handling in backup deletion
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* Refactor backup deletion logic to skip CSI snapshot cleanup on tarball download failure
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* prevent backup deletion when errors occur
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* added logger
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
…ion (velero-io#9700)

* Add delay to avoid race conditions during VolumeSnapshotContent deletion
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* updated changelog
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* Updated Changelog
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
@github-actions github-actions Bot requested review from Lyndon-Li and ywk253100 April 15, 2026 11:14
@priyansh17 priyansh17 added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Apr 15, 2026
@priyansh17 priyansh17 force-pushed the user/priyansh/backport-9693-9700 branch from bfeab62 to 2d73c4b Compare April 15, 2026 11:16
anshulahuja98
anshulahuja98 previously approved these changes Apr 15, 2026
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.85%. Comparing base (d8ab30c) to head (2140750).
⚠️ Report is 1 commits behind head on release-1.16.

Files with missing lines Patch % Lines
pkg/controller/backup_deletion_controller.go 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.16    #9726   +/-   ##
=============================================
  Coverage         59.84%   59.85%           
=============================================
  Files               370      370           
  Lines             32034    32048   +14     
=============================================
+ Hits              19172    19183   +11     
- Misses            11362    11365    +3     
  Partials           1500     1500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kaovilai
Copy link
Copy Markdown
Collaborator

Are you backporting to 1.17 and 1.18 too?

kaovilai
kaovilai previously approved these changes Apr 15, 2026
@blackpiglet
Copy link
Copy Markdown
Contributor

@priyansh17
Please delete the changelog files, because there PR IDs are wrong.

Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
@priyansh17
Copy link
Copy Markdown
Collaborator Author

@priyansh17 Please delete the changelog files, because there PR IDs are wrong.

Sure, updated changelog file Thanks

@priyansh17 priyansh17 removed the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Apr 16, 2026
@priyansh17
Copy link
Copy Markdown
Collaborator Author

Are you backporting to 1.17 and 1.18 too?

Yes, will raise PRs for the same

@priyansh17 priyansh17 changed the title Backport PR #9693 and #9700 Backport PR #9693 and #9700 to Release-1.16 Apr 16, 2026
@kaovilai kaovilai merged commit 221e19f into velero-io:release-1.16 Apr 16, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants