fix: improve error handling for discarded hooks in WaitExecHookHandler#9750
fix: improve error handling for discarded hooks in WaitExecHookHandler#9750priyansh17 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
The suggested fix adds an error along with the warning logger so it moves the Restore to PartiallyFailed Instead of Success with warnings logged. |
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
08bc63c to
9fb9e89
Compare
I think the behavior of this PR is correct. |
Signed-off-by: Priyansh Choudhary im1706@gmail.com
Thank you for contributing to Velero!
Please add a summary of your change
The early-return in HandleHooks (when byContainer empty or pod==nil) should Record(... hookFailed=true ...) in the multiHookTracker, or else never Add such hooks in the first place. Otherwise, tracker cannot complete, and the restore gets stuck forever.
Does your change fix a particular issue?
Yes
Fixes #(issue)
#9749
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.