Align restore reconcile tests with backup phase validation#9874
Draft
Copilot wants to merge 2 commits into
Draft
Align restore reconcile tests with backup phase validation#9874Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
✅ Deploy Preview for velero canceled.
|
Copilot
AI
changed the title
[WIP] Fix code as per review comment 3337885080
Align restore reconcile tests with backup phase validation
Jun 2, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
TestRestoreReconcilestill had cases usingdefaultBackup()inReadyToStart, which now fails restore validation before the intended code path executes. This update applies the review suggestion by setting backup phase explicitly toCompletedonly in cases meant to proceed past validation.pkg/controller/restore_controller_test.go.Does your change fix a particular issue?
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.