feat(notifications): add local sender avatars across surfaces by Jasonnnz · Pull Request #42627 · vellum-ai/vellum-assistant

Jasonnnz · 2026-09-11T23:32:15Z

Summary

Add independent, default-off push-avatar-sender and local-notification-avatar client flags.
Carry exact scoped assistant identity through notification intents, preparation, IPC, permission confirmation, and tap routing.
Add an iOS app-local native notification owner while keeping APNs Notification Service Extension delivery separate.
Unify Android app-local and data-only FCM delivery under one process-wide coordinator with page-bound ownership negotiation, shared focus suppression, full-key deduplication, and one owned sound.
Add prepared browser notification icons, macOS Communication Notification sender presentation, Windows helper sender parity, and Linux Electron icon preservation.
Document architecture, compatibility boundaries, manual QA, and rollout gates in docs/notification-avatar-local-qa.md.

Platform dependency

Depends on vellum-assistant-platform#10502 at 8694633c77b4183a1e0f24442b30fc41b6345bfa.

That platform PR is open, merge-clean, and green, but it is not merged or applied. Before this application PR merges, both flag definitions must exist in the target platform configuration, the configuration must be applied, and both flags must be verified OFF.

Validation

Exact 28-file changed TypeScript manifest: 695 passed, 0 failed, one Bun process per file. Electron native-auth passed 7/7 with loopback access.
Six focused Wave 8 web suites: 155 passed, 0 failed.
Notification tap navigation: 15 passed, 0 failed.
iOS host-less AppTests: passed on an iPhone 17 simulator with CODE_SIGNING_ALLOWED=NO.
Scoped changed-web ESLint over an asserted 41-file manifest: passed.
Typechecks: web, assistant fast typecheck, ipc-contract, electron-desktop, macOS, Windows, and Linux passed.
Focused Android Gradle tests: blocked because the validation host has no Java runtime.

Manual QA and rollout status

This PR is draft and is not rollout-ready. No manual route is marked PASS.

Blocked evidence includes signed physical-device iOS app-local and APNs/NSE runs, Android device and Firebase runs, signed packaged macOS native delivery, packaged Windows parity, and a defined browser/PWA support matrix. macOS fallback and permission confirmation are not run. Linux has one non-gating regression smoke that is not run.

The canonical case matrix, evidence format, prerequisites, current statuses, and rollout gates are in docs/notification-avatar-local-qa.md. No release, feature-flag activation, or platform apply is included.

Review focus

Android coordinator ownership and FCM/SSE arrival-order invariants.
iOS one-owner behavior across native rewrite timeouts and ambiguous bridge completion.
Exact identity isolation across scope changes, pop-outs, logout, rename, and late preparation.
Backward compatibility for old web/new shell, new web/old shell, notification-block FCM, plain fallbacks, acknowledgments, actions, and tap metadata.

Jasonnnz · 2026-09-11T23:32:24Z

Review attention: risk is concentrated in the Android process-wide ownership and deduplication state machine, the iOS one-owner timeout behavior, and scoped identity invalidation across renderer and account transitions. Please review those paths before presentation details. The exact changed-TypeScript manifest is green, but focused Android Gradle execution is still blocked by the missing Java runtime, and all signed device/package QA remains blocked or not run as recorded in docs/notification-avatar-local-qa.md. The companion platform flag PR #10502 is green but not merged or applied; both flags must be applied and verified off before this PR can merge.

Jasonnnz · 2026-09-12T00:54:09Z

@codex review the current head f887e1f

Jasonnnz · 2026-09-12T00:54:09Z

@devin review the current head f887e1f

chatgpt-codex-connector · 2026-09-12T00:54:21Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-12T02:29:07.386846Z	`aa9f720`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-09-12T01:03:11Z

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: f887e1fbaa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f887e1fbaa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Jasonnnz · 2026-09-12T02:16:39Z

@codex review
@devin review

Please re-review current head e1406ea. The renderer reload generation finding is addressed with eager session registration and source-keyed native generation translation across Electron, iOS, and Android. Focused web, IPC, and Electron tests pass; 72 iOS logic tests pass; and the full iOS simulator build succeeds. Android local execution remains unavailable on this host because no Java runtime is installed, so the PR Android checks remain the execution gate.

Jasonnnz · 2026-09-12T02:19:36Z

@codex review
@devin review

Please review current head aa9f720. This follow-up removes the sandbox-unsafe node:crypto import exposed by the Linux, macOS, and Windows preload guards, using the Web Crypto global already available to the preload. All three preload-external tests, the notification preload tests, and the shared Electron type-check pass locally.

Jasonnnz · 2026-09-12T02:20:37Z

@codex review current head aa9f720

Jasonnnz · 2026-09-12T02:20:37Z

@devin review current head aa9f720

chatgpt-codex-connector · 2026-09-12T02:29:06Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: aa9f720fa6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Vellum Assistant added 26 commits September 11, 2026 14:53

feat(flags): register local notification avatars

fd13636

fix(web): scope avatar query retention

f930adf

feat(notifications): include assistant name in intents

aa43f78

feat(ipc): define scoped notification contracts

8f6aae9

refactor(ios): share notification helpers

d3e4ab7

refactor(android): share notification inputs

bd8ff71

docs(flags): link local avatar companion PR

3816908

fix(ipc): support targeted identity reset revisions

35ba49d

feat(android): coordinate notification delivery in memory

90b1424

refactor(web): centralize notification sender resolution

385616f

fix(android): harden notification delivery ownership

a3fd588

feat(ios): own local sender notification delivery

8d32387

fix(web): retain notification generation safety

bddeb18

fix(ios): retain notification generation safety

f395b8d

feat(android): add scoped sender notification bridge

c6dcf0a

feat(web): prepare notification avatars across surfaces

09ac9a3

feat(web): carry assistant identity through notification intents

2324daa

refactor(web): centralize notification platform ids

8d5087d

refactor(web): route notification taps with explicit assistant identity

ebd2499

feat(web): show prepared avatars in browser notifications

9f899fc

feat(desktop): retain notification senders across windows in memory

979d601

feat(macos): personalize notification permission confirmation

cf84057

feat(ios): route local notifications through native ownership

ba2e9ca

feat(android): unify foreground push and local notification ownership

4676418

test(web): use distinct notification sender ids

92e1495

docs(notifications): record local avatar verification and rollout gates

614c0cb

fix(android): avoid notification writer id shadowing

f887e1f

Jasonnnz marked this pull request as ready for review September 12, 2026 01:03

chatgpt-codex-connector Bot reviewed Sep 12, 2026

View reviewed changes

Comment thread clients/web/src/runtime/notification-avatar.ts

fix(notifications): fence renderer identity generations

e1406ea

fix(notifications): keep preload sandbox safe

aa9f720

Jasonnnz merged commit 7a5af32 into main Sep 14, 2026
36 checks passed

Jasonnnz deleted the Jasonnnz/notification-avatar-local-v2 branch September 14, 2026 15:42

vex-assistant-bot Bot mentioned this pull request Sep 14, 2026

fix(providers): strip orphaned UTF-16 surrogates from every outbound LLM request, keep memory v3 previews whole #42682

Merged

Navigation Menu

Uh oh!

feat(notifications): add local sender avatars across surfaces - #42627

feat(notifications): add local sender avatars across surfaces#42627
Jasonnnz merged 29 commits into
mainfrom
Jasonnnz/notification-avatar-local-v2

Jasonnnz commented Sep 11, 2026

Uh oh!

Jasonnnz commented Sep 11, 2026

Uh oh!

Jasonnnz commented Sep 12, 2026

Uh oh!

Jasonnnz commented Sep 12, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 12, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Sep 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Jasonnnz commented Sep 12, 2026

Uh oh!

Jasonnnz commented Sep 12, 2026 •

edited

Loading

Uh oh!

Jasonnnz commented Sep 12, 2026

Uh oh!

Jasonnnz commented Sep 12, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Jasonnnz commented Sep 11, 2026

Summary

Platform dependency

Validation

Manual QA and rollout status

Review focus

Uh oh!

Jasonnnz commented Sep 11, 2026

Uh oh!

Jasonnnz commented Sep 12, 2026

Uh oh!

Jasonnnz commented Sep 12, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot commented Sep 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Jasonnnz commented Sep 12, 2026

Uh oh!

Jasonnnz commented Sep 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jasonnnz commented Sep 12, 2026

Uh oh!

Jasonnnz commented Sep 12, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chatgpt-codex-connector Bot commented Sep 12, 2026 •

edited

Loading

Jasonnnz commented Sep 12, 2026 •

edited

Loading