feat: improve fetch gauges script - #49
Open
airtoonricardo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this PR with a script I created during the release, to allow fetching all existing gauges from a list of PoolFactories with a smaller number of RPC calls.
I also deployed a helper contract for this purpose (i.e.: the
GaugeSugarused in the script), but didn't push it to this repo to avoid extra maintenance, since the contract only needs to be deployed once for now.At the moment this PR is just pending a clean up, since the script is already functional, so feel free to take over the PR to wrap it up. Some initial cleanups that come to mind would be to fix the CI, create an additional folder for the
abis& to move the hardcoded constants to fetch gauges somewhere else (i.e.: to the env file), but feel free to address any other cleanups as you see fit.cc: @imollov