Skip to content

Conversation

@xinhash
Copy link

@xinhash xinhash commented Dec 30, 2019

I wanted to use the same package in knex seeds as generatePasswordHash('password').Adding argon2 as dependency and creating a generatePasswordHash and verifyPasswordHash by my own would've been either led to duplication of work or discarding this package in general. Hence I added support for these feature in this feature.

@venables
Copy link
Owner

Thanks @xinhash -- can you please re-submit without the prettier/husky/lint-staged commits? I do not want to add that as part of this PR.

@xinhash
Copy link
Author

xinhash commented Jan 1, 2020

Thanks @xinhash -- can you please re-submit without the prettier/husky/lint-staged commits? I do not want to add that as part of this PR.

Sorry for late reply. I've done that.

@venables
Copy link
Owner

venables commented Jan 7, 2020

@xinhash it still appears there's a bunch of style changes in this PR, can you get it down to the minimum changes required to achieve your goal please?

@xinhash
Copy link
Author

xinhash commented Jan 8, 2020

@xinhash it still appears there's a bunch of style changes in this PR, can you get it down to the minimum changes required to achieve your goal please?

Sorry. I had vscode's formatOnSave on 😐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants