-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(dashboard): Add global search command palette #3746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: minor
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
| return routes.some(route => { | ||
| // Support exact match and pattern matching | ||
| if (route.includes('*')) { | ||
| const pattern = route.replace('*', '.*'); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 months ago
To fix the problem, we need to ensure that all occurrences of the * wildcard in the route pattern are replaced with .* so that the resulting regular expression matches any sequence of characters at each wildcard position. The best way to do this is to use a regular expression with the global (g) flag in the replace method: route.replace(/\*/g, '.*'). This change should be made on line 120 in the file packages/dashboard/src/lib/components/global-search/quick-actions-registry.ts. No additional imports or definitions are needed.
-
Copy modified line R120
| @@ -119,3 +119,3 @@ | ||
| if (route.includes('*')) { | ||
| const pattern = route.replace('*', '.*'); | ||
| const pattern = route.replace(/\*/g, '.*'); | ||
| const regex = new RegExp(`^${pattern}$`); |
|
|
Appreciate this 🔥 |




Description
This PR introduces a global search command palette feature to the dashboard, providing users with a unified interface to quickly search and perform actions across the application.
Key Features
Components Added
Breaking changes
No breaking changes - this is an additive feature.
Checklist
📌 Always:
👍 Most of the time: