fix: resolve Ktor JSON serialization, missing compiler plugin, and discount calculation bugs - #12
Open
harsh786 wants to merge 2 commits into
Open
fix: resolve Ktor JSON serialization, missing compiler plugin, and discount calculation bugs#12harsh786 wants to merge 2 commits into
harsh786 wants to merge 2 commits into
Conversation
…scount calculation bugs - Install Ktor content negotiation + kotlinx JSON to fix 406 on GET /products?country=Sweden - Add Kotlin serialization compiler plugin for @serializable runtime support - Fix discount application to be multiplicative (sequential) instead of additive Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes three bugs identified during testing of the discount service.
Bugs Fixed
ContentNegotiation+kotlinx.serializationJSON plugin on the server soGET /products?country=Swedenreturns JSON correctly.@Serializablemodels have generated serializers available at runtime.Files Changed
FIXES.md– Full bug report with root cause and fix details