Add SOP activity bar chart to workflow dashboard#74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/workflow_product_module.pyto addget_sop_run_totals()which aggregates run counts by SOP id.dashboard_html()to render a new "SOP Activity (Bar Chart)" card at the top of the dashboard and compute relative bar widths from the run totals.Testing
pytest -q tests/test_workflow_product_module.pyand all tests passed (5 passed).python -m src.workflow_product_moduleand verified a smoke GET of/dashboardviacurl -sSf http://localhost:8080/dashboardreturned the updated HTML including the new chart card.Codex Task