Skip to content

Make null streamLength when catching exception #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximPlusov merged 1 commit into from
Jul 28, 2026
Merged

Make null streamLength when catching exception #740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions validation-model/src/main/java/org/verapdf/gf/model/factory/operators/OperatorParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,11 +625,11 @@ private static void processInlineImage(List<org.verapdf.model.operator.Operator>
&& (gs.isProcessColorOperators() || Boolean.TRUE.equals(imageParameters.getBooleanKey(ASAtom.IM)))) {

arguments.add(imageParameters);
long streamLength = 0;
Long streamLength = null;
try {
streamLength = ((ASMemoryInStream) rawOperator.getImageData()).getStreamLength();
} catch (IOException e) {
LOGGER.log(Level.SEVERE, "Error during computing inline image data stream length", e);
LOGGER.log(Level.SEVERE, "Error during computing inline image data stream length");
Comment on lines 631 to +632

@coderabbitai coderabbitai Bot Jul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Locate and inspect the referenced source line and surrounding logging practice.
if [ -f validation-model/src/main/java/org/verapdf/gf/model/factory/operators/OperatorParser.java ]; then
  echo "== referenced source =="
  sed -n '610,645p' validation-model/src/main/java/org/verapdf/gf/model/factory/operators/OperatorParser.java | nl -ba -v610
else
  echo "referenced file missing"
fi

echo
echo "== LOGGER usage in OperatorParser =="
rg -n 'LOGGER\.log|Logger\.' validation-model/src/main/java/org/verapdf/gf/model/factory/operators/OperatorParser.java || true

echo
echo "== nearby catch/logging patterns for IOException in source =="
python3 - <<'PY'
from pathlib import Path
p = Path('validation-model/src/main/java/org/verapdf/gf/model/factory/operators/OperatorParser.java')
if p.exists():
    text = p.read_text()
    for start in range(text.find('LOGGER.log(Level.SEVERE'), 0, -1):
        pass
    idx = text.find('LOGGER.log')
    print('first LOGGER.log index', idx)
PY

Repository: veraPDF/veraPDF-validation

Length of output: 228

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Determine whether the caught IOException is re-thrown/attached,
# whether the Java Logger overload accepting a Throwable is available,
# and inspect whether line 631 is inside an inline-image parsing path.
echo "== imports and class declarations =="
sed -n '1,80p' validation-model/src/main/java/org/verapdf/gf/model/factory/operators/OperatorParser.java | nl -ba -v1

echo
echo "== method context =="
python3 - <<'PY'
from pathlib import Path
p = Path('validation-model/src/main/java/org/verapdf/gf/model/factory/operators/OperatorParser.java')
lines = p.read_text().splitlines()
for i in range(500, 660):
    print(f'{i+1}: {lines[i]}')
PY

echo
echo "== references to streamLength and inline image handling =="
rg -n 'streamLength|inline image|Inline|inline' validation-model/src/main/java/org/verapdf/gf/model/factory/operators/OperatorParser.java || true

echo
echo "== Java Logger overload availability via javadoc/source in toolchain =="
if command -v javac >/dev/null 2>&1; then
  javac -version
  javadoc -help 2>&1 | head -20 || true
  echo "checking java.util.logging.Logger.signature in JDT classpath?"
else
  echo "javac unavailable"
fi

Repository: veraPDF/veraPDF-validation

Length of output: 241

🏁 Script executed:

#!/bin/bash
set -euo pipefail

FILE='validation-model/src/main/java/org/verapdf/gf/model/factory/operators/OperatorParser.java'

echo "== referenced source =="
if [ -f "$FILE" ]; then
  sed -n '610,645p' "$FILE" | cat -n
else
  echo "referenced file missing"
fi

echo
echo "== LOGGER usage in OperatorParser =="
rg -n 'LOGGER\.log|Logger\.' "$FILE" || true

echo
echo "== method context =="
python3 - <<'PY'
from pathlib import Path
p = Path('validation-model/src/main/java/org/verapdf/gf/model/factory/operators/OperatorParser.java')
if not p.exists():
    raise SystemExit(0)
lines = p.read_text().splitlines()
for i in range(500, 660):
    if i < len(lines):
        print(f'{i+1}: {lines[i]}')
PY

echo
echo "== references to streamLength and inline image handling =="
rg -n 'streamLength|inline image|Inline|inline' "$FILE" || true

echo
echo "== Java Logger overload availability =="
if command -v javac >/dev/null 2>&1; then
  javac -version
  javadoc -help 2>&1 | head -20 || true
else
  echo "javac unavailable"
fi

Repository: veraPDF/veraPDF-validation

Length of output: 11650

Preserve the exception cause in the log.

Keeping streamLength as null is correct for downstream handling, but omitting e drops the stack trace when getStreamLength() fails. Log the thrown exception as the cause.

🔧 Proposed fix 
-                LOGGER.log(Level.SEVERE, "Error during computing inline image data stream length");
+                LOGGER.log(Level.SEVERE, "Error during computing inline image data stream length", e);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
} catch (IOException e) {
LOGGER.log(Level.SEVERE, "Error during computing inline image data stream length", e);
LOGGER.log(Level.SEVERE, "Error during computing inline image data stream length");
} catch (IOException e) {
LOGGER.log(Level.SEVERE, "Error during computing inline image data stream length", e);
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@validation-model/src/main/java/org/verapdf/gf/model/factory/operators/OperatorParser.java`
around lines 631 - 632, Update the IOException handler in OperatorParser to pass
the caught exception e to LOGGER.log along with the existing message, preserving
the stack trace while keeping streamLength null for downstream handling.

}
processedOperators.add(new GFOp_BI(new ArrayList<>()));
processedOperators.add(new GFOp_ID(arguments));
Expand Down
2 changes: 1 addition & 1 deletion validation-model/src/main/java/org/verapdf/gf/model/impl/operator/inlineimage/GFOp_EI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class GFOp_EI extends GFOpInlineImage implements Op_EI {

private final PDResourcesHandler resourcesHandler;
private final org.verapdf.pd.colors.PDColorSpace inheritedFillCS;
private final long dataStreamLength;
private final Long dataStreamLength;

public GFOp_EI(List<COSBase> arguments, PDResourcesHandler resourcesHandler,
org.verapdf.pd.colors.PDColorSpace inheritedFillCS, Long dataStreamLength) {
Expand Down
Loading