Skip to content

Remove Exception stack trace from Logs - #746

Merged
MaximPlusov merged 1 commit into
integrationfrom
logs
Aug 6, 2026
Merged

Remove Exception stack trace from Logs#746
MaximPlusov merged 1 commit into
integrationfrom
logs

Conversation

@LonelyMidoriya

@LonelyMidoriya LonelyMidoriya commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved error logging by removing detailed exception and stack-trace output from routine diagnostic messages.
    • Preserved existing validation, parsing, fallback, and error-handling behavior.
    • Reduced unnecessary diagnostic detail across reporting, metadata fixing, validation, and accessibility checks.

@LonelyMidoriya LonelyMidoriya self-assigned this Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f2b404d-9f95-4a33-8559-2ad36fd634d2

📥 Commits

Reviewing files that changed from the base of the PR and between 1deb0d8 and b0ca08f.

📒 Files selected for processing (22)
  • feature-reporting/src/main/java/org/verapdf/features/gf/GFFeatureParser.java
  • feature-reporting/src/main/java/org/verapdf/features/gf/objects/GFColorSpaceFeaturesObjectAdapter.java
  • feature-reporting/src/main/java/org/verapdf/features/gf/objects/GFICCProfileFeaturesObjectAdapter.java
  • metadata-fixer/src/main/java/org/verapdf/metadata/fixer/gf/MetadataFixerImpl.java
  • metadata-fixer/src/main/java/org/verapdf/metadata/fixer/gf/impl/model/MetadataImpl.java
  • metadata-fixer/src/main/java/org/verapdf/metadata/fixer/gf/impl/model/PDFDocumentImpl.java
  • metadata-fixer/src/main/java/org/verapdf/metadata/fixer/gf/impl/schemas/AdobePDFSchemaImpl.java
  • metadata-fixer/src/main/java/org/verapdf/metadata/fixer/gf/impl/schemas/DublinCoreSchemaImpl.java
  • metadata-fixer/src/main/java/org/verapdf/metadata/fixer/gf/impl/schemas/XMPBasicSchemaImpl.java
  • metadata-fixer/src/main/java/org/verapdf/metadata/fixer/gf/utils/DateConverter.java
  • validation-model/src/main/java/org/verapdf/gf/model/GFModelParser.java
  • validation-model/src/main/java/org/verapdf/gf/model/impl/external/GFEmbeddedFile.java
  • validation-model/src/main/java/org/verapdf/gf/model/impl/external/GFPKCSDataObject.java
  • validation-model/src/main/java/org/verapdf/gf/model/impl/external/GFTrueTypeFontProgram.java
  • validation-model/src/main/java/org/verapdf/gf/model/impl/operator/textshow/GFGlyph.java
  • validation-model/src/main/java/org/verapdf/gf/model/impl/operator/textshow/GFOpTextShow.java
  • validation-model/src/main/java/org/verapdf/gf/model/impl/pd/GFPDContentStream.java
  • validation-model/src/main/java/org/verapdf/gf/model/impl/pd/GFPDMetadata.java
  • validation-model/src/main/java/org/verapdf/gf/model/impl/pd/font/GFPDCIDFont.java
  • validation-model/src/main/java/org/verapdf/gf/model/impl/pd/util/XMPChecker.java
  • wcag-validation/src/main/java/org/verapdf/gf/model/factory/chunks/ChunkParser.java
  • wcag-validation/src/main/java/org/verapdf/gf/model/impl/sa/GFSAContentStream.java

📝 Walkthrough

Walkthrough

The change removes caught exception objects from selected log calls across five modules. It preserves diagnostic messages, control flow, fallback results, and most exception propagation. One date-conversion wrapper and two model-parsing wrappers no longer retain exception causes.

Changes

Exception detail reduction

Layer / File(s) Summary
Feature reporting logging
feature-reporting/src/main/java/org/verapdf/features/gf/...
Feature-reporting logs retain their messages without throwable arguments.
Metadata fixer logging
metadata-fixer/src/main/java/org/verapdf/metadata/fixer/gf/MetadataFixerImpl.java, metadata-fixer/src/main/java/org/verapdf/metadata/fixer/gf/impl/model/...
Metadata-fixer logs omit exception objects. Existing error results, status values, and return paths remain unchanged.
Metadata schema exception handling
metadata-fixer/src/main/java/org/verapdf/metadata/fixer/gf/impl/schemas/..., metadata-fixer/src/main/java/org/verapdf/metadata/fixer/gf/utils/DateConverter.java
Schema logs omit caught exceptions. Schema rethrows remain unchanged. Date conversion no longer chains the caught exception.
Validation model error handling
validation-model/src/main/java/org/verapdf/gf/model/...
Validation-model logs omit throwable arguments. Stream and file parsing wrappers no longer retain caught IOException causes.
WCAG validation logging
wcag-validation/src/main/java/org/verapdf/gf/model/...
WCAG logs omit caught exceptions while preserving messages and fallback behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: maximplusov

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 13.16% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing exception stack traces from log statements across the affected modules.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch logs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MaximPlusov
MaximPlusov merged commit 181c6d5 into integration Aug 6, 2026
16 of 20 checks passed
@MaximPlusov
MaximPlusov deleted the logs branch August 6, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants