Implement missing type choice extensions #37
Merged
+900
−414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement type choice extensions for ProfileTypeChoice allowing values of types other than the ones explicitly specified in the spec. Signed-off-by: setrofim <[email protected]>
Implement type extension for CryptoKeyTypeChoice, allowing values of types other than the ones explicitly specified in the spec. Signed-off-by: setrofim <[email protected]>
Implement type extension for InstanceIdTypChoice, allowing values of types other than the ones explicitly specified by the spec. Signed-off-by: setrofim <[email protected]>
Implement type extensions for GroupIdTypeChoice, allowing values of types other than the ones explicitly specified by the spec. Signed-off-by: setrofim <[email protected]>
Implement type extensions for RawValueTypeChoice, allowing values of types other than the ones explicitly specified by the spec. This also removes TaggedJsonValue type, as it is no longer used. Signed-off-by: setrofim <[email protected]>
Add value extensions for TagRelTypeChoice enum, allowing values not specified by the spec. Note: despite the "type choice" suffix in the type's name, this not actually intended to support type extensions, but only new values indicating alternative relationships. Signed-off-by: setrofim <[email protected]>
Implement type extensions for TagIdTypeChoice, allowing values of types other than those explicitly specified by the spec. Signed-off-by: setrofim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement extensions for types that are supposed to have them.
This addresses #28
NOTE:
concise-rim-type-choice, despite the-type-choicesuffix is not extendible -- it can only be either signed or unsigned CoRIM.tag-rel-ty-pe-choiceis not a true "type choice"; it does not allow arbitary types; instead, the extension poin is there to allow other values.