A number of fixes due to recent changes in dependencies/cargo #47
+93
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the locked version of derive_more crate to 2.1.1. This has recently started detecting and giving errors for problems that were previously ignored. - TryFrom derived implementation only works for unit variants. Since most of our enums have variants that contain data, this is of little use, and so the drive is removed (we already have custom TryFrom implementations where they are relevant). - For the few enums that only have unit variants (and so the derived implementation may be used), add the try_from(repr) attribute. The attribute was always needed, however it being missing was silently ignore in past versions of the derive_more crate. Signed-off-by: setrofim <[email protected]>
cargo has started giving warnings when lifetimes elided in the arguments are hidden in the returns. Signed-off-by: setrofim <[email protected]>
Minor issues that started being reported by the recent cargo versions. Signed-off-by: setrofim <[email protected]>
paulhowardarm
approved these changes
Jan 22, 2026
Collaborator
paulhowardarm
left a comment
paulhowardarm
left a comment
There was a problem hiding this comment.
Looks good, thanks for jumping on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
derive_moreissues that started being reproted by the recent versions of the cratecargoAddresses: #45