Update Readme #50
Merged
Update Readme #50
+38
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now reflect the current behavior of the scripts Signed-off-by: Ian Chin Wang <[email protected]>
Update make install-tools to install all protobuf and OpenAPI codegen tools, including opai-codegen, protobuf-gen-go and protobuf-gen-go-grpc Signed-off-by: Ian Chin Wang <[email protected]>
cowbon
requested review from
deeglaze,
iolivergithub,
jraman567 and
thomas-fossati
as code owners
thomas-fossati
approved these changes
Jun 11, 2025
Contributor
thomas-fossati
left a comment
thomas-fossati
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I have inlined a couple of editorial suggestions for your consideration.
Signed-off-by: Ian Chin Wang <[email protected]> Co-authored-by: Thomas Fossati <[email protected]>
Co-authored-by: Thomas Fossati <[email protected]>
Co-authored-by: Thomas Fossati <[email protected]>
Co-authored-by: Thomas Fossati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update readme to reflect the preferred method of installing dependencies and current usage.