Auto-scaling for AWS deployment. #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v3 has been deprecated, causing integration-tests run to fail. Signed-off-by: Sergei Trofimov <[email protected]>
Add the missing psycopg2 (Postres client lib) to requirements.txt for the aws deployment Python enviroment. Signed-off-by: Sergei Trofimov <[email protected]>
Collaborator
yogeshbdeshpande
left a comment
yogeshbdeshpande
left a comment
There was a problem hiding this comment.
Thanks for these changes, will continue reviewing the same -today/tomorrow!
setrofim
force-pushed
the
aws
branch
2 times, most recently
from
32049ab to
218d795
Compare
Contributor
thomas-fossati
left a comment
thomas-fossati
left a comment
There was a problem hiding this comment.
An impressive amount of work, thanks!
I have a few easy questions inline.
| protocol: https | ||
| cert: /opt/veraison/certs/provisioning.crt | ||
| cert-key: /opt/veraison/certs/provisioning.key | ||
| protocol: http |
Contributor
There was a problem hiding this comment.
Just so that I understand: we do HTTP here because TLS termination is on the load balancers?
Collaborator
Author
There was a problem hiding this comment.
Yes, that is correct.
setrofim
force-pushed
the
aws
branch
3 times, most recently
from
3e3a3ee to
729c6df
Compare
thomas-fossati
approved these changes
Feb 12, 2025
yogeshbdeshpande
approved these changes
Feb 13, 2025
Collaborator
yogeshbdeshpande
left a comment
yogeshbdeshpande
left a comment
There was a problem hiding this comment.
Put some minor questions and .nits but in general LGTM! You can submit, addressing the minor points!
Restructure AWS deployment to use load balancers and auto-scaled service instances. - This deployment requires a domain to be registered in Route53. - TLS is relegated to the load balancers. This requires for a certificate associate with the registered domain to be created inside ACM. - RDS and EC2 instances now run inside private subnets and are not directly accessible by the outside world. A sentinel instance exists to provide indirect access, e.g. when setting up the databases. Signed-off-by: Sergei Trofimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-writes the AWS depoyment to use auto-scaling groups behind load balancers rather than fixed instances. This also improves the security of the deployment by moving EC2 and RDS instances into private subnets. Finally, the service is now publically accessible via a fixed domain name.