Update Rich Text editor to support placeholder attribute#1655
Merged
engram-design merged 1 commit intoverbb:craft-4from Dec 9, 2023
Merged
Update Rich Text editor to support placeholder attribute#1655engram-design merged 1 commit intoverbb:craft-4from
engram-design merged 1 commit intoverbb:craft-4from
Conversation
Member
|
Thanks for this! It's a tiny bit hacky, and I'd rather Pell sort this out themselves, but this is pretty much all we can do. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the already existing placeholder on the multi-line text form field to the Rich Text editor by configuring the Pell onChange function, the SCSS for the .fui-rich-text-content class, and the appropriate Twig template.
This feature emulates a moderately popular PR on the Pell repository, but rather than configuring Pell with different options, I chose to modify the onChange function to handle the empty HTML.