Open
Conversation
…lt Chrome flags Mirrors Playwright ignoreDefaultArgs API, allowing users to remove specific hardcoded Chrome flags from build_chrome_args(). Supports exact match (--disable-sync) and prefix match (--disable-features also removes --disable-features=Translate). Available via CLI flag, AGENT_BROWSER_IGNORE_DEFAULT_ARGS env var, and config file (ignoreDefaultArgs). Plumbed through daemon env forwarding and launch hash for relaunch detection.
Contributor
|
@ShivanKaul is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
ShivanKaul
changed the title
ShivanKaul
changed the title
Collaborator
|
Thanks for the contribution, @ShivanKaul! Two small issues to fix before merge:
|
Author
|
@ctate thanks for the review! Addressed your comments. |
Author
|
@ctate gentle ping for this! Any other thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #682
My use-case is to control a Chromium browser with working component updates. Component updater is currently hard-disabled in agent-browser code.
Playwright allows you to ignoreDefaultArgs, allowing users to remove specific hardcoded Chrome flags from build_chrome_args(). There should be a similar option for
agent-browser.This new flag is available via CLI flag, AGENT_BROWSER_IGNORE_DEFAULT_ARGS env var, and config file (
ignoreDefaultArgs). Plumbed through daemon env forwarding and launch hash for relaunch detection.Note: I used Claude Code to assist with the PR. Happy to work through any feedback. This shouldn't be a large change.