fix: re-apply ignore_https_errors to recording context#1178
Merged
ctate merged 1 commit intovercel-labs:mainfrom Apr 7, 2026
Merged
fix: re-apply ignore_https_errors to recording context#1178ctate merged 1 commit intovercel-labs:mainfrom
ctate merged 1 commit intovercel-labs:mainfrom
Conversation
Security.setIgnoreCertificateErrors is session-scoped, so creating a new BrowserContext for recording (Target.createBrowserContext) starts with the default certificate validation enabled, ignoring the launch-time flag. Store ignore_https_errors in BrowserManager alongside download_path, and re-apply Security.setIgnoreCertificateErrors to the new session after recording context creation — matching the existing pattern for download behavior re-application. Fixes vercel-labs#1172
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Thanks for fixing this @juniper929! |
Contributor
Author
|
My pleasure! @ctate |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
record startcallsTarget.createBrowserContextto create an isolated BrowserContext for the recording session.Security.setIgnoreCertificateErrorsis session-scoped — it only applies to the session it was sent on and doesnot propagate to new contexts. As a result, the recording context always starts with default certificate validation enabled, regardless of
--ignore-https-errorsorAGENT_BROWSER_IGNORE_HTTPS_ERRORS.Symptoms reported in #1172:
record startThe fix stores
ignore_https_errorsinBrowserManageralongsidedownload_path, and re-appliesSecurity.setIgnoreCertificateErrorsto the new session after context creation — matching the existing pattern forBrowser.setDownloadBehaviorre-application.Fixes #1172