fix: inherit viewport dimensions in recording context#1208
Open
jin-2-kakaoent wants to merge 4 commits intovercel-labs:mainfrom
Open
fix: inherit viewport dimensions in recording context#1208jin-2-kakaoent wants to merge 4 commits intovercel-labs:mainfrom
jin-2-kakaoent wants to merge 4 commits intovercel-labs:mainfrom
Conversation
When `record start` creates a new browser context, it now re-applies the current viewport settings (from `set viewport` or `set device`) so the recording resolution matches what the user configured instead of falling back to the default 1280×720. Closes vercel-labs#1207
Contributor
|
@hyunjinee is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
record startcreates a new browser context, it now re-applies the current viewport settings so the recording resolution matches what the user configured instead of falling back to the default 1280×720set viewportandset devicepaths now store viewport state onDaemonStatefor re-applicationdownload_pathandignore_https_errorsBefore / After
set viewport 1920 1080set viewport 800 600set device "iphone 16 pro"Test plan
e2e_recording_inherits_viewport— sets 800×600 viewport, starts recording, verifieswindow.innerWidth/innerHeightin the recording contextffprobeacross three resolutions (1920×1080, 800×600, iPhone 16 Pro)Closes #1207