dashboard: add --addr flag for configurable bind address#1214
Open
jmjoy wants to merge 2 commits intovercel-labs:mainfrom
Open
dashboard: add --addr flag for configurable bind address#1214jmjoy wants to merge 2 commits intovercel-labs:mainfrom
jmjoy wants to merge 2 commits intovercel-labs:mainfrom
Conversation
Contributor
|
@jmjoy is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dashboard server was hardcoded to bind to 127.0.0.1, making it impossible to run the dashboard inside a Docker container and access it from the host machine. Requests from the host
(or any external network) would be rejected since 127.0.0.1 only accepts connections from within the container's own network namespace.
Solution
Add a new --addr CLI flag to agent-browser dashboard start that allows specifying the bind address. The default remains 127.0.0.1 for full backwards compatibility.
Usage
Changes
cli/src/native/stream/dashboard.rs— run_dashboard_server now accepts addr: &str instead of hardcoding 127.0.0.1:portcli/src/main.rs— Parses --addr from CLI args, passes it to the daemon via AGENT_BROWSER_DASHBOARD_ADDR env varcli/src/output.rs— Updated --help output with new flag and examplesBackwards compatibility
No breaking changes. Omitting --addr defaults to 127.0.0.1, matching the previous behavior exactly.