fix: preserve the active page when removing earlier tabs#1220
Open
officialasishkumar wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: preserve the active page when removing earlier tabs#1220officialasishkumar wants to merge 1 commit intovercel-labs:mainfrom
officialasishkumar wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Adjust tab-removal bookkeeping so closing or losing a page before the active tab keeps the session pointed at the same logical page instead of silently shifting to the next one. Add regression coverage for earlier-tab removal, later-tab removal, last-tab clamping, and the empty-page case. Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Contributor
|
@officialasishkumar is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tab closeand destroyed-target cleanupCloses #1219.
Validation
cargo fmt --manifest-path cli/Cargo.tomlcargo test --manifest-path cli/Cargo.toml active_page_index_after_removalcargo test --manifest-path cli/Cargo.toml tab_AGENT_BROWSER_ARGS=--no-sandbox: open A/B/C/D, switch to C, runtab close 0, verifyget titlestill returnsCand the active tab is now index1cargo clippy --manifest-path cli/Cargo.toml --all-targets -- -D warnings