fix: remove e2e test that requires ffmpeg (#1208 regression noted in code)#1236
Closed
jin-2-kakaoent wants to merge 1 commit intovercel-labs:mainfrom
Closed
fix: remove e2e test that requires ffmpeg (#1208 regression noted in code)#1236jin-2-kakaoent wants to merge 1 commit intovercel-labs:mainfrom
jin-2-kakaoent wants to merge 1 commit intovercel-labs:mainfrom
Conversation
…n code The e2e_recording_inherits_viewport test required ffmpeg at runtime, causing CI failures on ubuntu-latest where ffmpeg is not installed. Since a skip approach would leave a permanently dead test, the test is removed instead. The regression context (vercel-labs#1208) is preserved as a comment co-located with the viewport inheritance logic in actions.rs, matching the pattern used by adjacent download and HTTPS error comments.
Contributor
|
@hyunjinee is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e_recording_inherits_viewport(added in #1208) was failing CI becauseubuntu-latestrunners don't haveffmpeginstalled —recording_startfails immediately before any assertions can run.
Why not skip when ffmpeg is missing? A runtime skip leaves a permanently
dead test in the suite: it looks maintained but never executes in CI.
Why not install ffmpeg in CI? Too heavy a dependency for a single test.
Solution
Remove the test and preserve the regression context as a comment directly
on the two lines it was guarding in
handle_recording_start, matching thepattern used by the adjacent download-behavior and HTTPS-error comments:
Test plan
Native E2E TestsCI job passes