Skip to content

fix: remove e2e test that requires ffmpeg (#1208 regression noted in code)#1236

Closed
jin-2-kakaoent wants to merge 1 commit intovercel-labs:mainfrom
hyunjinee:fix/remove-ffmpeg-dependent-e2e-test
Closed

fix: remove e2e test that requires ffmpeg (#1208 regression noted in code)#1236
jin-2-kakaoent wants to merge 1 commit intovercel-labs:mainfrom
hyunjinee:fix/remove-ffmpeg-dependent-e2e-test

Conversation

@jin-2-kakaoent
Copy link
Copy Markdown
Contributor

@jin-2-kakaoent jin-2-kakaoent commented Apr 14, 2026

Summary

e2e_recording_inherits_viewport (added in #1208) was failing CI because
ubuntu-latest runners don't have ffmpeg installed — recording_start
fails immediately before any assertions can run.

Why not skip when ffmpeg is missing? A runtime skip leaves a permanently
dead test in the suite: it looks maintained but never executes in CI.

Why not install ffmpeg in CI? Too heavy a dependency for a single test.

Solution

Remove the test and preserve the regression context as a comment directly
on the two lines it was guarding in handle_recording_start, matching the
pattern used by the adjacent download-behavior and HTTPS-error comments:

// Inherit the current viewport dimensions into the recording context.
// Without this, the recording context resets to the default 1280×720
// regardless of what the user previously set. Regression: #1208
if let Some((w, h, scale, mobile)) = viewport {
    let _ = mgr.set_viewport(w, h, scale, mobile).await;
}

Test plan

  • Native E2E Tests CI job passes

…n code

The e2e_recording_inherits_viewport test required ffmpeg at runtime,
causing CI failures on ubuntu-latest where ffmpeg is not installed.
Since a skip approach would leave a permanently dead test, the test is
removed instead. The regression context (vercel-labs#1208) is preserved as a
comment co-located with the viewport inheritance logic in actions.rs,
matching the pattern used by adjacent download and HTTPS error comments.
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 14, 2026

@hyunjinee is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@jin-2-kakaoent jin-2-kakaoent changed the title fix: remove ffmpeg-dependent e2e test, document viewport regression in code fix: remove e2e test that requires ffmpeg (#1208 regression noted in code) Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants