fix: prevent screenshot --annotate from hanging on complex pages#659
Open
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: prevent screenshot --annotate from hanging on complex pages#659juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Conversation
On pages with many interactive elements, `screenshot --annotate` would fire hundreds of `boundingBox()` calls simultaneously via `Promise.all`, saturating Chrome's CDP connection and causing timeouts/hangs. Fix: process elements in batches of 20 with a 1-second timeout per element. Elements that time out are skipped (treated as null) rather than blocking the entire operation. Closes vercel-labs#509 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On pages with many interactive elements,
screenshot --annotatefires hundreds ofboundingBox()calls simultaneously viaPromise.all, saturating Chrome's CDP connection and causing timeouts/hangs (confirmed on both macOS and Linux).Root cause
Object.entries(refs)on a complex page can yield 200+ entries. Callinglocator.boundingBox()for all of them in a singlePromise.alloverwhelms the CDP websocket connection, causing Chrome to become unresponsive.Fix
Before
After
Test plan
Closes #509
🤖 Generated with Claude Code