fix: capture all network requests including document navigations#663
Open
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: capture all network requests including document navigations#663juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Previously, `network requests` only captured XHR/fetch because request tracking was only activated on-demand via `startRequestTracking()`, which was called when the user first ran `network requests`. This meant navigations that occurred before that call were never recorded. Fix: move request tracking into `setupPageTracking()` so it is always active for every page from the moment it is created. This captures all network activity including document navigations, redirects, and resource loads — not just XHR/fetch. `startRequestTracking()` is kept as a no-op for backwards compatibility. Closes vercel-labs#555 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
network requestsonly captured XHR/fetch calls because request tracking was activated on-demand when the user first ran the command. Navigations occurring before that call were never recorded.Root cause
startRequestTracking()registered apage.on('request')listener only when called explicitly. Document navigations (page loads, redirects, form submissions) that occurred before the user rannetwork requestswere invisible.Fix
Move request tracking into
setupPageTracking()so it is always active for every page from creation. This captures all network activity:startRequestTracking()is kept as a no-op for backwards compatibility.Before
After
Test plan
network requestscaptures document navigationsnetwork requests --filterstill works for filteringCloses #555
🤖 Generated with Claude Code