fix: check browser.isConnected() in isLaunched()#668
Open
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: check browser.isConnected() in isLaunched()#668juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Conversation
When a browser is manually closed or crashes, isLaunched() previously returned true because the browser reference was still non-null. This caused subsequent commands (like goto) to throw confusing errors. Now isLaunched() also checks browser.isConnected(), correctly returning false when the browser process is gone. Fixes vercel-labs#212 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isLaunched()now checksbrowser.isConnected()in addition to the null checkisLaunched()correctly returns falseProblem
After a browser was manually closed or crashed,
isLaunched()still returnedtruebecause the browser reference was non-null. This caused subsequent commands likegototo throw confusing errors instead of indicating the browser needs to be relaunched.Test plan
Fixes #212
🤖 Generated with Claude Code