fix: detect position modifiers misused after find locators#669
Open
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: detect position modifiers misused after find locators#669juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Conversation
When users write `find role spinbutton first fill '20'`, the `first` keyword ends up in the subaction position causing a confusing Zod validation error. Now the CLI detects this pattern and returns a helpful error message explaining that first/last/nth are locator types, not modifiers, with the correct syntax. Fixes vercel-labs#364 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| return Err(ParseError::InvalidValue { | ||
| message: format!( | ||
| "\"{}\" cannot be used as a modifier after \"{}\". \ | ||
| Use it as the primary locator: find {} <selector> [action] [text]", |
Contributor
There was a problem hiding this comment.
Error message and usage hint are incorrect when nth is misused as a position modifier after a locator type (e.g., find role spinbutton nth).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
first/last/nthappears in the subaction position after a semantic locatorProblem
Running
find role spinbutton first fill '20'produces:Now it produces:
Test plan
cargo checkpassesFixes #364
🤖 Generated with Claude Code