fix: use browser.getLocator() for ref support in all commands#670
Open
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: use browser.getLocator() for ref support in all commands#670juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
juliobrasa wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Multiple commands (innerText, innerHTML, highlight, clear, selectText, setvalue, dispatch, count, boundingBox, nth, scroll hover, multiselect, screenshot) were using page.locator() directly instead of browser.getLocator(), which meant @ref arguments (like @e1) would fail with "Unsupported token" CSS parsing errors. Now all commands consistently use browser.getLocator() which handles both ref resolution and regular CSS selectors. Fixes vercel-labs#128 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page.locator(command.selector)withbrowser.getLocator(command.selector)in 13 command handlersProblem
Multiple commands used
page.locator()directly which only accepts CSS selectors. When users passed @ref arguments from snapshot output, they got:browser.getLocator()handles both refs and CSS selectors, and was already used by some commands but not consistently.Affected commands
innerText, innerHTML (content), innerHTML (html), highlight, clear, selectText, setvalue, dispatch, count, boundingBox, nth, scroll (hover target), multiselect, screenshot (selector)
Test plan
Fixes #128
🤖 Generated with Claude Code