fix: handle relative URLs in WebSocket domain filter#767
Open
Jah-yee wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: handle relative URLs in WebSocket domain filter#767Jah-yee wants to merge 1 commit intovercel-labs:mainfrom
Jah-yee wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Resolves TypeError when WebSocket connections use relative URLs like /__webpack_hmr (webpack HMR endpoints). - domain-filter.ts: Use location.href as base URL for new URL() - network.rs: Same fix for inline WebSocket filter script Previously, new URL(url) threw TypeError on relative URLs because it requires an absolute URL. Now we resolve against location.href to properly handle relative paths.
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves TypeError when WebSocket connections use relative URLs like /__webpack_hmr (webpack HMR endpoints).
Problem
In
src/domain-filter.tsandcli/src/native/network.rs, the WebSocket URL was parsed with:new URL(url)requires an absolute URL. Relative paths (e.g./__webpack_hmr) need a base URL to resolve against, otherwise the constructor throws aTypeError.Solution
Use
location.hrefas the base URL when parsing:This allows relative WebSocket URLs (like webpack HMR endpoints) to be properly resolved against the current page origin without throwing an error.
Files Changed
src/domain-filter.ts—_checkUrl()functioncli/src/native/network.rs— inline WebSocket filter script