fix(core): support numeric strings in min and max validation - #318
Open
ken8203 wants to merge 1 commit into
Open
fix(core): support numeric strings in min and max validation#318ken8203 wants to merge 1 commit into
ken8203 wants to merge 1 commit into
Conversation
Contributor
|
@ken8203 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
ken8203
marked this pull request as ready for review
August 13, 2026 04:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minandmaxvalidators to evaluate finite numeric strings.NaN, andInfinity.Motivation
HTML inputs store their values as strings, including
<input type="number">. The shadcn renderer therefore writes values such as"12"to state.The built-in
minandmaxvalidators currently accept only JavaScript numbers, so a valid number input can fail both range checks:This change safely converts non-empty numeric strings before comparison while avoiding broad JavaScript coercion for values such as
"",false, ornull.Related but non-overlapping: #306 tightens the standalone
numericvalidator. This PR only addresses range validation for input values.Testing
vitest run packages/core/src/validation.test.ts --environment node --maxWorkers 1— 103 tests passedpnpm --filter @json-render/core build