fix(react): stabilize streaming renders - #325
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ctate
reviewed
Aug 23, 2026
ctate
reviewed
Aug 23, 2026
ctate
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #311.
Append-paced streaming rebuilt the complete spec for every patch. Because each
ElementRendererreceived the new spec reference, unchanged elements still executed on every patch. Freshbindingsand resolved-props wrappers could then turn consumer effects into aMaximum update depth exceededloop.This change:
Public spec, streaming, renderer, and binding contracts remain unchanged.
Evidence
On a 26-element workload with 200 separately committed patches touching one element:
The regression matrix covers direct complete specs, later children, state updates, repeat callback freshness, functions and directives, shared-child DAGs, cyclic graphs, 12,000-node depth, watch cleanup after unmount, error recovery, cyclic runtime state, and
BigIntvalues.Verification
pnpm test: 1,085/1,085pnpm type-check: 59/59pnpm lint: 14/14PASS476e27a: passRemaining gap
Chrome heap retention and Fiber collection after forced GC were not measured locally. The tests directly prove removal of the repeated React work and update loop, but do not claim a browser heap profile.