Add conditional scrolling to useScrollToBottom hook #956
+48
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce IntersectionObserver to detect if the bottom element is in viewport - Only scroll to bottom when the user is near or at the bottom
|
@xxxijustwei is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
- Extract scroll logic into reusable hook - Add scrollToBottom function for manual control - Use useEffect to trigger scroll on new user messages - Rename refs for clarity and consistency - Update types and return object from hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the
useScrollToBottomhook by introducing conditional scrolling behavior. It uses anIntersectionObserverto detect whether the bottom element is in the viewport. Automatic scrolling to the bottom only occurs when the user is near or at the bottom, preventing unwanted scrolling when viewing earlier content (e.g., in a chat or log view).Changes
shouldScrollRefto track whether scrolling to the bottom is needed.IntersectionObserverto monitor the visibility of the bottom element (endRef).scrollIntoViewonly when the bottom element is visible.IntersectionObserverin theuseEffectreturn function.