fix: Add missing ".catch" handler for tool execution promise #11502
+144
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vercel-ai-sdk
bot
added
the
documentation
DongSeonYoo
changed the title
lgrammel
reviewed
Jan 5, 2026
Collaborator
|
will also revert typo fixes. please open a separate pr so we have clean commits |
lgrammel
approved these changes
Jan 5, 2026
Merged
lgrammel
added a commit
that referenced
this pull request
Jan 6, 2026
## Related Issues Follow up from #11502 --------- Co-authored-by: Lars Grammel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
After experiencing issues similar to #7694 (tool calls getting stuck),
I looked into the tool execution code and found another potential case
where streams could hang due to unhandled promise rejection.
Summary
Add missing
.catch()handler toexecuteToolCallpromise inrunToolsTransformation.Verification
Added test cases to verify the fix:
should handle error thrown in async tool executionshould handle error thrown in sync tool executionBoth tests confirm that:
outstandingToolResultsis cleaned uppnpm vitest run src/generate-text/run-tools-transformation.test.ts # 13 tests passedChecklist
Related Issues
Related to #7694 - similar pattern where unhandled error states can cause streams to get stuck