fix(react): prevent double resume in React StrictMode #11509
+79
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9610
This PR adds a ref guard to prevent
resumeStream()from being called twice when React StrictMode double-invokes effects during development.Problem
When using
useChatwithresume: true, refreshing the page mid-stream causes duplicate stream requests because React StrictMode runs effects twice (mount → unmount → mount). The current implementation has no protection against this:This leads to:
onDatacallbacks being called twice per server writeSolution
Add a
hasResumedRefthat tracks whether resume has already been attempted:Testing
Added a test case that renders the component in
<React.StrictMode>and verifies only one resume request is made despite effects running twice.Checklist