feat: add workflow-safe signed tool approvals to WorkflowAgent - #19976
Merged
Conversation
1 task
gr2m
approved these changes
Aug 31, 2026
Contributor
|
🚀 Published in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
WorkflowAgent consumers need authenticated approval replay so client-supplied message history cannot forge or alter approvals for sensitive tools.
Summary
Added constructor- and stream-level experimental_toolApprovalSecret support using an environment-variable reference. WorkflowAgent signs and verifies approvals inside durable steps, binds signatures to approval and tool-call details, preserves signatures through stream transformations, and never serializes the raw secret.
Testing
Added runtime and type tests covering signed issuance, valid replay, missing and tampered signatures, changed IDs, tool names and inputs, unsigned compatibility, UI transformation, reconnect replay, and cross-workflow resumption.
End-to-end Validation
Documentation
Updated the tool approval guide, WorkflowAgent guide, and API reference with configuration, precedence, security, persistence, key availability, and rotation guidance.
Related Issues
Fixes #19964