fix: OPA policy approval gates fail open on unrecognized decision payloads - #19981
Open
ai-sdk-factory[bot] wants to merge 3 commits into
Open
fix: OPA policy approval gates fail open on unrecognized decision payloads#19981ai-sdk-factory[bot] wants to merge 3 commits into
ai-sdk-factory[bot] wants to merge 3 commits into
Conversation
Co-authored-by: AUTHENSOR <250658088+AUTHENSOR@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Unrecognized OPA policy payloads normalized to no opinion, allowing protected tools to execute without approval and creating a fail-open policy gate.
Root Cause
normalizeOpaDecision mapped every unsupported non-null result to not-applicable, which generateText treats as direct execution. The reproduction confirmed four malformed decision shapes executed the protected tool.
Summary
Changed OPA decision normalization to deny unrecognized non-null results with a clear reason while preserving nullish and explicit not-applicable behavior. Updated documentation and added a patch changeset.
Testing
Added normalization coverage for malformed decision variants and an end-to-end generateText regression test confirming unrecognized decisions produce execution-denied results.
End-to-end Validation
pnpm -C examples/ai-functions exec tsx src/reproduction/policy-opa-unrecognized-decision-fail-open.tsexited successfully; all four malformed decisions were denied and the protected tool did not execute.Related Issues
Fixes #19978
Closes #19980