Feat(amazon bedrock): Add support for cohere embed models #6190
+478
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for Cohere embedding models with customizable settings including input type, truncation, and embedding types. - Implemented separate embedding methods for Cohere and Titan models within the BedrockEmbeddingModel class. - Updated response handling to accommodate both simple and complex embedding formats for Cohere. - Revised the BedrockEmbeddingSettings interface to include Cohere-specific settings.
- Introduced unit tests for the `doEmbed` method, covering both Cohere and Titan models. - Enhanced test cases to validate handling of single and multiple input values, image inputs, and various embedding types. - Updated server response mocks to reflect new embedding scenarios.
…lution - Added compiler options for module resolution and module type to support Node16 in the TypeScript configuration file, specific to bedrock sdk requirements.
- Added new export types for BedrockEmbeddingModelId, BedrockEmbeddingSettings, and CohereEmbeddingSettings in the index file
lgrammel
reviewed
May 7, 2025
|
Please add a changeset. |
lgrammel
reviewed
May 7, 2025
| /** | ||
| * Settings specific to Cohere embedding models. | ||
| */ | ||
| cohere?: CohereEmbeddingSettings; |
There was a problem hiding this comment.
Not a fan of this solution and the overall way of how the functionality is integrated. Need to think more about how to do this.
There was a problem hiding this comment.
Could you expand a bit more on what you would like to see? I can add more type safety for sure. But are you thinking more just rethinking the overall integration as a whole? I could split cohere and titan into their own class and then just set the general bedrockembeddingmodel to be a thin wrapper for the subclasses.
lgrammel
reviewed
May 7, 2025
| /** | ||
| * Specifies the types of embeddings you want to have returned. | ||
| */ | ||
| embedding_types?: Array<'float' | 'int8' | 'uint8' | 'binary' | 'ubinary'>; |
There was a problem hiding this comment.
We only support float atm.
lgrammel
reviewed
May 7, 2025
|
Ideally this would be on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The current Amazon Bedrock provider implementation doesn't properly support Cohere embedding models, which use a different request format compared to Titan models. This causes issues when attempting to use Cohere models for embeddings through the Amazon Bedrock provider.
Summary
bedrock-embedding-model.tsto handle Cohere-specific request and response formatsBedrockEmbeddingSettingstype in the package's index file to fix TypeScript errors when using the updated package in third-party applicationsVerification
I tested all changes using the automated test suite and verified functionality with each Bedrock embedding model (including Cohere models) in a Next.js 15 app router application using the updated dist outputs. All tests passed successfully, confirming that both Titan and Cohere embedding models now work as expected.
Tasks
pnpm prettier-fixin the project root)Related Issues
Fixes #5055