fix(providers/amazon-bedrock): strip empty text content to avoid API errors #6255
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors.
Without this, with maxSteps set, we sometimes see messages sent to the API like this:
```
{
role: 'assistant',
content: [ { text: '\n\n' }, { toolUse: [Object] } ]
},
```
This leads to API errors like this:
```
The text field in the ContentBlock object at messages.$n.content.0 is blank. Add text to the text field, and try again.
```
This change simply filters out this useless but apparently harmful message.
MaxAller
commented
May 9, 2025
| @@ -204,6 +204,11 @@ export function convertToBedrockChatMessages(prompt: LanguageModelV1Prompt): { | |||
|
|
|||
| switch (part.type) { | |||
| case 'text': { | |||
| // Skip empty text blocks | |||
| if (!part.text.trim()) { | |||
There was a problem hiding this comment.
I am making the assumption here that this is sufficient for Bedrock's definition of "blank", but it seems reasonable enough to me.
|
thanks for this! i am going to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Without this, with maxSteps set, we sometimes see messages sent to the API like this:
This leads to API errors like this:
This happens often enough, maybe half the time in my experience, to cause a lot of pain on our side.
Summary
This change simply filters out this useless but apparently harmful message.
Verification
I've been running with this change locally for a day and haven't seen the issue recur, and nothing else seems to have obviously broken.
Tasks
pnpm changesetin the project root)pnpm prettier-fixin the project root)Future Work
Related Issues
Fixes #6254.