Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated api-routes-apollo-server-and-client example to utilize app router. #73334

Open
wants to merge 23 commits into
base: canary
Choose a base branch
from

Conversation

PapatMayuri
Copy link
Contributor

This PR updates the api-routes-apollo-server-and-clientexample for using the App Router.
Here are the changes that have been made:

  • I renamed the pages folder and moved it to the app folder.
  • Added the layout.tsx file as part of the App Router.
  • Moved component folder to app folder.
  • Moved api folder to app folder.
  • Added apollo folder to lib folder
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue was opened via the examples template. label Nov 29, 2024
@ijjk
Copy link
Member

ijjk commented Nov 29, 2024

Allow CI Workflow Run

  • approve CI run for commit: 750af35

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

socket-security bot commented Nov 29, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@as-integrations/[email protected] None 0 24.7 kB martinnabhan

View full report↗︎

@PapatMayuri PapatMayuri marked this pull request as ready for review November 29, 2024 13:09
@samcx samcx self-requested a review November 29, 2024 22:39
@samcx
Copy link
Member

samcx commented Dec 2, 2024

@PapatMayuri Please make sure to test the example before pushing up a PR and having it ready for a review. Unfortunately, this one has a multitude of issues.

You may have update the example to be something like this → https://github.com/apollographql/apollo-client-nextjs/tree/main/examples/app-dir-experiments.

@PapatMayuri
Copy link
Contributor Author

Sure @samcx, Thanks for the feedback. I'll make sure to test the example thoroughly before submitting a PR and will follow the approach outlined in the (https://github.com/apollographql/apollo-client-nextjs/tree/main/examples/app-dir-experiments). I'll also address any issues that arise during testing to ensure everything works smoothly before submitting for review.

@PapatMayuri
Copy link
Contributor Author

Hi @samcx I have updated the example please check & let me know if there are any changes needs to be done.

@samcx
Copy link
Member

samcx commented Dec 3, 2024

@PapatMayuri This example is still not working. Did you make sure to run the example?

@PapatMayuri
Copy link
Contributor Author

Yes @samcx I checked the example it is working. Give me some time I will recheck and update you.

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. Documentation Related to Next.js' official documentation. labels Dec 9, 2024
@ijjk ijjk added Font (next/font) Related to Next.js Font Optimization. tests Turbopack Related to Turbopack with Next.js. type: next labels Dec 9, 2024
Copy link

vercel bot commented Dec 9, 2024

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding, @huozhi:

packages/next/src/server/config.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. Documentation Related to Next.js' official documentation. examples Issue was opened via the examples template. Font (next/font) Related to Next.js Font Optimization. tests Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants