fix: using punycode from punycode repo and not native node #75394

wowczarczyk · 2025-01-28T11:01:17Z

The precompiled node-fetch was requiring the deprecated native punycode module

fixes #75313

ijjk · 2025-01-28T11:01:47Z

Allow CI Workflow Run

approve CI run for commit: 0e52a9a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

ijjk · 2025-01-28T21:58:36Z

Failing test suites

Commit: 8794542

pnpm test test/integration/amp-export-validation/test/index.test.js

AMP Validation on Export > production mode > should have shown errors during build

Expand output

● AMP Validation on Export › production mode › should have shown errors during build

expect(received).toMatch(expected)

Expected pattern: /error.*The mandatory attribute 'height' is missing in tag 'amp-video'\./
Received string:  "   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   ▲ Next.js 15.2.0-canary.44·
   Checking validity of types ...
   Creating an optimized production build ...
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
 ✓ Compiled successfully
   Collecting page data ...
   Generating static pages (0/8) ...
   Generating static pages (2/8)··
 ⚠ Linting is disabled.
Error occurred prerendering page \"/dog\". Read more: https://nextjs.org/docs/messages/prerender-error
AssertionError: Assertion failed: WebAssembly is uninitialized

  at new module$contents$goog$asserts_AssertionError (../evalmachine.<anonymous>:106:1695)
  at module$contents$goog$asserts_doAssertFailure (../evalmachine.<anonymous>:107:354)
  at goog.asserts.assertExists (../evalmachine.<anonymous>:109:142)
  at Object.module$contents$amp$validator_validateString [as validateString] (../evalmachine.<anonymous>:2663:108)
  at Validator.validateString (../packages/next/dist/compiled/amphtml-validator/index.js:1:20650)
  at validateAmp (../packages/next/dist/export/routes/pages.js:87:34)
  at async exportPagesPage (../packages/next/dist/export/routes/pages.js:104:13)
  at async Span.traceAsyncFn (../packages/next/dist/trace/trace.js:156:20)
  at async exportPage (../packages/next/dist/export/worker.js:352:18)
  Export encountered an error on /dog, exiting the build.
   ⨯ Static worker exited with code: 1 and signal: null
  "
  at Object.toMatch (integration/amp-export-validation/test/index.test.js:28:29)

Read more about building and testing Next.js in contributing.md.

ijjk · 2025-01-28T22:01:05Z

Stats from current PR

Default Build

General

	vercel/next.js canary	wowczarczyk/next.js patch-punycode	Change
buildDuration	17.3s	14.7s	N/A
buildDurationCached	13.9s	11.6s	N/A
nodeModulesSize	392 MB	392 MB	N/A
nextStartRea..uration (ms)	409ms	390ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	wowczarczyk/next.js patch-punycode	Change
5306-HASH.js gzip	54.2 kB	54.2 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	240 B	242 B	N/A
main-HASH.js gzip	34.5 kB	34.5 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	wowczarczyk/next.js patch-punycode	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	wowczarczyk/next.js patch-punycode	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	wowczarczyk/next.js patch-punycode	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	wowczarczyk/next.js patch-punycode	Change
index.html gzip	524 B	523 B	N/A
link.html gzip	539 B	538 B	N/A
withRouter.html gzip	520 B	520 B	✓
Overall change	520 B	520 B	✓

Edge SSR bundle Size

	vercel/next.js canary	wowczarczyk/next.js patch-punycode	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	wowczarczyk/next.js patch-punycode	Change
middleware-b..fest.js gzip	675 B	673 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	wowczarczyk/next.js patch-punycode	Change
app-page-exp...dev.js gzip	393 kB	393 kB	✓
app-page-exp..prod.js gzip	132 kB	132 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	381 kB	381 kB	✓
app-page.run..prod.js gzip	128 kB	128 kB	✓
app-route-ex...dev.js gzip	39.3 kB	39.3 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	40.9 kB	40.9 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	31.5 kB	31.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	60.5 kB	60.5 kB	✓
Overall change	1.67 MB	1.67 MB	✓

build cache

	vercel/next.js canary	wowczarczyk/next.js patch-punycode	Change
0.pack gzip	2.11 MB	2.1 MB	N/A
index.pack gzip	75.1 kB	74.5 kB	N/A
Overall change	0 B	0 B	✓

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: 8794542

wowczarczyk · 2025-01-29T18:18:36Z

@ijjk I noticed that the check if precompiled libs are identical before/after build was failing, so I added the punycode replacement to the ncc task itself as well

wowczarczyk · 2025-02-03T18:29:34Z

@ijjk hey, what is going on with the checks? Do they need to be manually approved? Can we move forward with this?

feedthejim · 2025-02-06T16:22:13Z

@wowczarczyk I just realized we were solving the same thing! I integrated the idea behind your change in my PR, albeit in a slightly more straightforward way here #75741.

wowczarczyk · 2025-02-06T16:39:42Z

@wowczarczyk I just realized we were solving the same thing! I integrated the idea behind your change in my PR, albeit in a slightly more straightforward way here #75741. I'm gonna amend the commit to add you as a coauthor

Sounds good, I tried to be as delicate and non-invasive as possible with the code changes but yeah, your approach seems better in the long run. Cool stuff, thanks! 🙌

fix: using punycode from punycode repo and not native node

9ee6d1a

ijjk added the type: next label Jan 28, 2025

wowczarczyk mentioned this pull request Jan 28, 2025

Deprecation warning of "punycode" module in freshly created next js app in Windows 11 #75313

Open

chore: replacing punycode during ncc

0e52a9a

feedthejim added the CI approved Approve running CI for fork label Feb 6, 2025

Merge branch 'canary' into patch-punycode

8794542

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: using punycode from punycode repo and not native node #75394

fix: using punycode from punycode repo and not native node #75394

wowczarczyk commented Jan 28, 2025 •

edited

Loading

ijjk commented Jan 28, 2025 •

edited

Loading

ijjk commented Jan 28, 2025 •

edited

Loading

ijjk commented Jan 28, 2025 •

edited

Loading

wowczarczyk commented Jan 29, 2025

wowczarczyk commented Feb 3, 2025

feedthejim commented Feb 6, 2025 •

edited

Loading

wowczarczyk commented Feb 6, 2025

fix: using punycode from punycode repo and not native node #75394

Are you sure you want to change the base?

fix: using punycode from punycode repo and not native node #75394

Conversation

wowczarczyk commented Jan 28, 2025 • edited Loading

ijjk commented Jan 28, 2025 • edited Loading

ijjk commented Jan 28, 2025 • edited Loading

Failing test suites

ijjk commented Jan 28, 2025 • edited Loading

Stats from current PR

wowczarczyk commented Jan 29, 2025

wowczarczyk commented Feb 3, 2025

feedthejim commented Feb 6, 2025 • edited Loading

wowczarczyk commented Feb 6, 2025

wowczarczyk commented Jan 28, 2025 •

edited

Loading

ijjk commented Jan 28, 2025 •

edited

Loading

ijjk commented Jan 28, 2025 •

edited

Loading

ijjk commented Jan 28, 2025 •

edited

Loading

feedthejim commented Feb 6, 2025 •

edited

Loading