Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React from cbbe8666-20250213 to e670e72f-20250214 #76058

Open
wants to merge 6 commits into
base: canary
Choose a base branch
from

Conversation

@ijjk
Copy link
Member

ijjk commented Feb 14, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-e670e72f-20250214 Change
buildDuration 21.6s 19.7s N/A
buildDurationCached 18.5s 15.8s N/A
nodeModulesSize 393 MB 393 MB ⚠️ +3.19 kB
nextStartRea..uration (ms) 483ms 477ms N/A
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-e670e72f-20250214 Change
5271-HASH.js gzip 55.4 kB 55.4 kB N/A
6228c9d4-HASH.js gzip 56.9 kB 57.4 kB ⚠️ +434 B
7048.HASH.js gzip 168 B 168 B
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 246 B N/A
main-HASH.js gzip 34.9 kB 34.9 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB
Overall change 58.8 kB 59.2 kB ⚠️ +434 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-e670e72f-20250214 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-e670e72f-20250214 Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 193 B 192 B N/A
amp-HASH.js gzip 513 B 511 B N/A
css-HASH.js gzip 342 B 342 B
dynamic-HASH.js gzip 1.84 kB 1.84 kB N/A
edge-ssr-HASH.js gzip 265 B 264 B N/A
head-HASH.js gzip 363 B 360 B N/A
hooks-HASH.js gzip 393 B 390 B N/A
image-HASH.js gzip 4.59 kB 4.59 kB N/A
index-HASH.js gzip 268 B 266 B N/A
link-HASH.js gzip 2.35 kB 2.35 kB
routerDirect..HASH.js gzip 328 B 326 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 325 B 325 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.72 kB 3.72 kB
Client Build Manifests
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-e670e72f-20250214 Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-e670e72f-20250214 Change
index.html gzip 523 B 523 B
link.html gzip 538 B 537 B N/A
withRouter.html gzip 519 B 518 B N/A
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-e670e72f-20250214 Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 214 kB 214 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-e670e72f-20250214 Change
middleware-b..fest.js gzip 676 B 673 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.6 kB 31.6 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-e670e72f-20250214 Change
app-page-exp...dev.js gzip 395 kB 395 kB ⚠️ +158 B
app-page-exp..prod.js gzip 133 kB 133 kB N/A
app-page-tur..prod.js gzip 145 kB 146 kB N/A
app-page-tur..prod.js gzip 141 kB 141 kB N/A
app-page.run...dev.js gzip 382 kB 384 kB ⚠️ +1.38 kB
app-page.run..prod.js gzip 129 kB 129 kB N/A
app-route-ex...dev.js gzip 39.4 kB 39.4 kB N/A
app-route-ex..prod.js gzip 25.7 kB 25.7 kB N/A
app-route-tu..prod.js gzip 25.7 kB 25.7 kB N/A
app-route-tu..prod.js gzip 25.5 kB 25.5 kB N/A
app-route.ru...dev.js gzip 41 kB 39.1 kB N/A
app-route.ru..prod.js gzip 25.5 kB 25.5 kB N/A
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.72 kB 9.72 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.72 kB 9.72 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 31.6 kB 31.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 61.2 kB 61.2 kB N/A
Overall change 885 kB 886 kB ⚠️ +1.53 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-e670e72f-20250214 Change
0.pack gzip 2.12 MB 2.12 MB N/A
index.pack gzip 76.9 kB 78.6 kB ⚠️ +1.69 kB
Overall change 76.9 kB 78.6 kB ⚠️ +1.69 kB
Diff details
Diff for middleware.js

Diff too large to display

Diff for 5271-HASH.js

Diff too large to display

Diff for 6228c9d4-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: 34349d2

@ijjk
Copy link
Member

ijjk commented Feb 14, 2025

Failing test suites

Commit: 34349d2

pnpm test test/integration/node-fetch-keep-alive/test/index.test.js (turbopack)

  • node-fetch-keep-alive > dev > should send keep-alive for json API
  • node-fetch-keep-alive > dev > should send keep-alive for getStaticProps
  • node-fetch-keep-alive > dev > should send keep-alive for getStaticPaths
  • node-fetch-keep-alive > dev > should send keep-alive for getServerSideProps
  • node-fetch-keep-alive > production mode > should send keep-alive for json API
  • node-fetch-keep-alive > production mode > should send keep-alive for getStaticProps
  • node-fetch-keep-alive > production mode > should send keep-alive for getStaticPaths
  • node-fetch-keep-alive > production mode > should send keep-alive for getServerSideProps
Expand output

● node-fetch-keep-alive › dev › should send keep-alive for json API

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  69 |
  70 |   function runTests() {
> 71 |     it('should send keep-alive for json API', async () => {
     |     ^
  72 |       const res = await fetchViaHTTP(appPort, '/api/json')
  73 |       const obj = await res.json()
  74 |       expect(obj).toEqual({ connection: 'keep-alive' })

  at it (integration/node-fetch-keep-alive/test/index.test.js:71:5)
  at runTests (integration/node-fetch-keep-alive/test/index.test.js:39:5)
  at describe (integration/node-fetch-keep-alive/test/index.test.js:22:3)
  at Object.describe (integration/node-fetch-keep-alive/test/index.test.js:21:1)

● node-fetch-keep-alive › dev › should send keep-alive for getStaticProps

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  75 |     })
  76 |
> 77 |     it('should send keep-alive for getStaticProps', async () => {
     |     ^
  78 |       const browser = await webdriver(appPort, '/ssg')
  79 |       const props = await browser.elementById('props').text()
  80 |       const obj = JSON.parse(props)

  at it (integration/node-fetch-keep-alive/test/index.test.js:77:5)
  at runTests (integration/node-fetch-keep-alive/test/index.test.js:39:5)
  at describe (integration/node-fetch-keep-alive/test/index.test.js:22:3)
  at Object.describe (integration/node-fetch-keep-alive/test/index.test.js:21:1)

● node-fetch-keep-alive › dev › should send keep-alive for getStaticPaths

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  83 |     })
  84 |
> 85 |     it('should send keep-alive for getStaticPaths', async () => {
     |     ^
  86 |       const browser = await webdriver(appPort, '/blog/first')
  87 |       const props = await browser.elementById('props').text()
  88 |       const obj = JSON.parse(props)

  at it (integration/node-fetch-keep-alive/test/index.test.js:85:5)
  at runTests (integration/node-fetch-keep-alive/test/index.test.js:39:5)
  at describe (integration/node-fetch-keep-alive/test/index.test.js:22:3)
  at Object.describe (integration/node-fetch-keep-alive/test/index.test.js:21:1)

● node-fetch-keep-alive › dev › should send keep-alive for getServerSideProps

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  91 |     })
  92 |
> 93 |     it('should send keep-alive for getServerSideProps', async () => {
     |     ^
  94 |       const browser = await webdriver(appPort, '/ssr')
  95 |       const props = await browser.elementById('props').text()
  96 |       const obj = JSON.parse(props)

  at it (integration/node-fetch-keep-alive/test/index.test.js:93:5)
  at runTests (integration/node-fetch-keep-alive/test/index.test.js:39:5)
  at describe (integration/node-fetch-keep-alive/test/index.test.js:22:3)
  at Object.describe (integration/node-fetch-keep-alive/test/index.test.js:21:1)

● node-fetch-keep-alive › production mode › should send keep-alive for json API

thrown: "Exceeded timeout of 60000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  42 |     'production mode',
  43 |     () => {
> 44 |       beforeAll(async () => {
     |       ^
  45 |         mockServer = createServer((req, res) => {
  46 |           // we can test request headers by sending them
  47 |           // back with the response

  at beforeAll (integration/node-fetch-keep-alive/test/index.test.js:44:7)
  at integration/node-fetch-keep-alive/test/index.test.js:41:56
  at Object.describe (integration/node-fetch-keep-alive/test/index.test.js:21:1)

● node-fetch-keep-alive › production mode › should send keep-alive for getStaticProps

thrown: "Exceeded timeout of 60000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  42 |     'production mode',
  43 |     () => {
> 44 |       beforeAll(async () => {
     |       ^
  45 |         mockServer = createServer((req, res) => {
  46 |           // we can test request headers by sending them
  47 |           // back with the response

  at beforeAll (integration/node-fetch-keep-alive/test/index.test.js:44:7)
  at integration/node-fetch-keep-alive/test/index.test.js:41:56
  at Object.describe (integration/node-fetch-keep-alive/test/index.test.js:21:1)

● node-fetch-keep-alive › production mode › should send keep-alive for getStaticPaths

thrown: "Exceeded timeout of 60000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  42 |     'production mode',
  43 |     () => {
> 44 |       beforeAll(async () => {
     |       ^
  45 |         mockServer = createServer((req, res) => {
  46 |           // we can test request headers by sending them
  47 |           // back with the response

  at beforeAll (integration/node-fetch-keep-alive/test/index.test.js:44:7)
  at integration/node-fetch-keep-alive/test/index.test.js:41:56
  at Object.describe (integration/node-fetch-keep-alive/test/index.test.js:21:1)

● node-fetch-keep-alive › production mode › should send keep-alive for getServerSideProps

thrown: "Exceeded timeout of 60000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  42 |     'production mode',
  43 |     () => {
> 44 |       beforeAll(async () => {
     |       ^
  45 |         mockServer = createServer((req, res) => {
  46 |           // we can test request headers by sending them
  47 |           // back with the response

  at beforeAll (integration/node-fetch-keep-alive/test/index.test.js:44:7)
  at integration/node-fetch-keep-alive/test/index.test.js:41:56
  at Object.describe (integration/node-fetch-keep-alive/test/index.test.js:21:1)

● Test suite failed to run

listen EADDRINUSE: address already in use :::44001

  28 |         res.end(JSON.stringify({ connection }))
  29 |       })
> 30 |       mockServer.listen(44001)
     |                  ^
  31 |       appPort = await findPort()
  32 |       app = await launchApp(appDir, appPort)
  33 |     })

  at Object.listen (integration/node-fetch-keep-alive/test/index.test.js:30:18)

● Test suite failed to run

listen EADDRINUSE: address already in use :::44001

  49 |           res.end(JSON.stringify({ connection }))
  50 |         })
> 51 |         mockServer.listen(44001)
     |                    ^
  52 |         const { stdout, stderr } = await nextBuild(appDir, [], {
  53 |           stdout: true,
  54 |           stderr: true,

  at Object.listen (integration/node-fetch-keep-alive/test/index.test.js:51:20)

Read more about building and testing Next.js in contributing.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants