fix(head): add warning for invalid children in next/head #87233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add development-time warning when invalid HTML elements are used as children of the next/head component. This helps developers identify issues early instead of seeing confusing "next-head-count is missing" errors at runtime. Valid children are: title, meta, link, script, style, base, noscript. Changes: - Add VALID_HEAD_TAGS constant - Add warnOnce() call for invalid element types in development - Create /errors/invalid-head-child.mdx documentation page Fixes vercel#20924
nextjs-bot
added
Documentation
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add development-time warning when invalid HTML elements are used as children of the
next/headcomponent. This helps developers identify issues early instead of seeing confusing "next-head-count is missing" errors at runtime.Problem
When developers accidentally put invalid elements like
<div>inside<Head>, they get a cryptic "next-head-count is missing" error that doesn't help identify the root cause.Solution
Add validation in development mode that warns about invalid children with a clear message:
Changes
VALID_HEAD_TAGSconstantwarnOnce()call for invalid element types in development/errors/invalid-head-child.mdxdocumentation pageHow tested
Manual testing with invalid Head children in development mode.
Fixes #20924