CI: Use minimumReleaseAge in pnpm workspace files#92480
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
bgw
changed the base branch from
bgw/stats-action-updates
to
graphite-base/92480
bgw
force-pushed
the
bgw/minimum-release-age
branch
from
6e8c367 to
5c052de
Compare
bgw
force-pushed
the
bgw/minimum-release-age
branch
from
5c052de to
345006c
Compare
ztanner
approved these changes
Apr 7, 2026
mmastrac
approved these changes
Apr 7, 2026
Contributor
mmastrac
left a comment
mmastrac
left a comment
There was a problem hiding this comment.
Approved, but I'd also approve a longer window.
eps1lon
reviewed
Apr 7, 2026
bgw
force-pushed
the
bgw/minimum-release-age
branch
from
345006c to
38fa9ec
Compare
Contributor
Tests Passed |
mmastrac
approved these changes
Apr 8, 2026
eps1lon
reviewed
Apr 8, 2026
| - react-dom-* | ||
| - react-experimental-builtin | ||
| - react-is | ||
| - react-is-builtin |
Member
There was a problem hiding this comment.
Does this work on aliases? This would be odd since you could effectively defeat the minimumReleaseAgeExclude by aliasing a malicious package to a trusted alias.
Member
Author
There was a problem hiding this comment.
Yes, it applies after resolution of aliases. At least that's what deepwiki claimed when I asked it.
Member
There was a problem hiding this comment.
If it applies after resolution, why list the *-builtin ones? Those are aliases not real npm packages.
Member
Author
There was a problem hiding this comment.
Maybe I'm not explaining this right. https://deepwiki.com/search/does-minimumreleaseageexclude_37cce44b-8975-4a63-a862-087b133fa393
Based on the codebase, minimumReleaseAgeExclude does use alias names if the package.json defines an alias for a package. The dependency resolution process resolves aliases before applying rules, so the exclusion logic works with the resolved (aliased) module names.
That implies that we must list the *-builtin package names.
Member
There was a problem hiding this comment.
That's not how it works though:
ERR_PNPM_NO_MATURE_MATCHING_VERSION Version 0.28.0-canary-404b38c7-20260408 (released 4 minutes ago) of scheduler-builtin does not meet the minimumReleaseAge constraint
-- https://github.com/vercel/next.js/actions/runs/24153975697/job/70488293803#step:7:41
Otherwise you could bypass it with an aliased install.
Fixing in #92535
Member
There was a problem hiding this comment.
Not sure why you used deepwiki. Is this some AI summary? pnpm docs are pretty clear:
The exclusion works by package name and applies to all versions of that package.
Member
There was a problem hiding this comment.
I meant dependency resolution by the package manager. The model used by deepwiki thought we were talking about module resolution at runtime.
bgw
force-pushed
the
bgw/minimum-release-age
branch
from
38fa9ec to
f506dc1
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on pnpm 10.x: #92283
Enables https://pnpm.io/settings#minimumreleaseage to protect against supply-chain attacks.
The
minimumReleaseAgeExcludelist is copied from https://github.com/vercel/front/blob/1c3a9458d970265e1fb5ec14ddfed9a0eab2abef/pnpm-workspace.yaml#L13, withreactandreact-domadded.