Fix custom server conf propagation#93645
Open
KurodaKayn wants to merge 1 commit intovercel:canaryfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87429
What?
Ensures config passed through
next({ conf })in a custom server is applied consistently across the router and render server pipeline.Why?
Custom server config such as
basePathwas loaded by the router server but not propagated into the internal render server. As a result, requests usingbasePathcould still render with the default config and return 404.How?
conffrom NextCustomServer.prepare() to getRequestHandlers()confthrough router-server.initialize() intoloadConfig()confintorenderServerOptsso the internal render server uses the same configbasePathpassed throughnext({ conf })Verification
pnpm install --frozen-lockfilepnpm --filter=next buildNEXT_SKIP_ISOLATE=1 NEXT_TEST_MODE=dev pnpm testheadless test/integration/custom-server/test/index.test.ts -t "with config provided through next"git diff --check