(1/1) Cover offline server action boundaries#93685
Closed
feedthejim wants to merge 1 commit into
Closed
Conversation
Contributor
Tests PassedCommit: 2f88a6c |
Contributor
Stats from current PR🔴 1 regression
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (9 files)Files with changes:
View diffsapp-page-exp..ntime.dev.jsfailed to diffapp-page-exp..time.prod.jsfailed to diffapp-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsfailed to diffapp-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsfailed to diffapp-page.runtime.dev.jsfailed to diffapp-page.runtime.prod.jsfailed to diffserver.runtime.prod.jsDiff too large to display 📎 Tarball URLCommit: 2f88a6c |
Contributor
Author
|
Closing this draft as part of the offline navigations first-usable restack. The current review stack is the 25-PR sequence rooted at #93622, ending at #93656, with #93648 folded into PR 22 and the stress-only rows deferred into named P1/P2 owners. The branch is intentionally left intact so the coverage can be recovered or rebundled later. Review guide: https://gist.github.com/feedthejim/b3d9fe26a7c05655fd57adcce371b93d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack Position
This is a focused request-shape stress PR stacked on #93683,
(1/1) Cover encoded slash offline misses.It covers the first
MUTATION-01row from the offline navigations stress plan: server action submissions while the browser is offline. This PR is intentionally test-only. It does not change service worker routing, fallback boot, or server action behavior.What Changed
does not serve fallback HTML to offline server action submissionsto the offline navigations production e2e suite.Behavior Covered
The e2e:
/docsonline and waits for the generated service worker.next-offline-navigation-fallback-servedmessages.invalidateOfflineNavigationActionserver action form.This protects the service worker contract: failed same-origin document navigations may receive the fallback document, but server action POSTs are unsafe app mutations and must pass through or fail normally.
Intentionally Not Covered Yet
Verification
pnpm prettier --with-node-modules --ignore-path .prettierignore --write test/production/app-dir/offline-navigations/offline-navigations.test.tsnpx eslint --config eslint.config.mjs --fix test/production/app-dir/offline-navigations/offline-navigations.test.tsgit diff --check -- test/production/app-dir/offline-navigations/offline-navigations.test.tsNEXT_SKIP_ISOLATE=1 pnpm test-start-turbo test/production/app-dir/offline-navigations/offline-navigations.test.ts -t "does not serve fallback HTML to offline server action submissions"pnpm test-start-webpack test/production/app-dir/offline-navigations/offline-navigations.test.ts -t "does not serve fallback HTML to offline server action submissions"